Reorganize our CRC source files again.

Now that we use CRC-32C in WAL and the control file, the "traditional" and
"legacy" CRC-32 variants are not used in any frontend programs anymore.
Move the code for those back from src/common to src/backend/utils/hash.

Also move the slicing-by-8 implementation (back) to src/port. This is in
preparation for next patch that will add another implementation that uses
Intel SSE 4.2 instructions to calculate CRC-32C, where available.

diff --git a/contrib/hstore/hstore_gist.c b/contrib/hstore/hstore_gist.c
index f375f5d3542594eaa81833a80177fc2c3b8eac35..06f3c9359b92e202ce1aee52dc4b0e023cbf25b6 100644 (file)
--- a/contrib/hstore/hstore_gist.c
+++ b/contrib/hstore/hstore_gist.c
@@ -6,7 +6,7 @@
 #include "access/gist.h"
 #include "access/skey.h"
 #include "catalog/pg_type.h"
-#include "common/pg_crc.h"
+#include "utils/pg_crc.h"
 
 #include "hstore.h"
 

diff --git a/contrib/ltree/crc32.c b/contrib/ltree/crc32.c
index 9e04037575a48589d187174064c78146f83549df..1c08d264f720992142503a47a2365fcf8b249fae 100644 (file)
--- a/contrib/ltree/crc32.c
+++ b/contrib/ltree/crc32.c
@@ -20,7 +20,7 @@
 #define TOLOWER(x) (x)
 #endif
 
-#include "common/pg_crc.h"
+#include "utils/pg_crc.h"
 #include "crc32.h"
 
 unsigned int

diff --git a/contrib/pg_trgm/trgm_op.c b/contrib/pg_trgm/trgm_op.c
index 5ec7f26524011282480f28b8275632cd9dab800f..1a71a2bef3ea8c187a3b68af9f5c7148729565d8 100644 (file)
--- a/contrib/pg_trgm/trgm_op.c
+++ b/contrib/pg_trgm/trgm_op.c
@@ -10,6 +10,7 @@
 #include "catalog/pg_type.h"
 #include "tsearch/ts_locale.h"
 #include "utils/memutils.h"
+#include "utils/pg_crc.h"
 
 PG_MODULE_MAGIC;
 

diff --git a/src/backend/access/transam/twophase.c b/src/backend/access/transam/twophase.c
index 4075a6f743a254e0c97f8c7db886ae2de3255161..b85a666ca1cc19ba6c71294399d632d161203ae8 100644 (file)
--- a/src/backend/access/transam/twophase.c
+++ b/src/backend/access/transam/twophase.c
@@ -1023,8 +1023,8 @@ EndPrepare(GlobalTransaction gxact)
    TwoPhaseFileHeader *hdr;
    char        path[MAXPGPATH];
    StateFileChunk *record;
-   pg_crc32    statefile_crc;
-   pg_crc32    bogus_crc;
+   pg_crc32c   statefile_crc;
+   pg_crc32c   bogus_crc;
    int         fd;
 
    /* Add the end sentinel to the list of 2PC records */
@@ -1034,7 +1034,7 @@ EndPrepare(GlobalTransaction gxact)
    /* Go back and fill in total_len in the file header record */
    hdr = (TwoPhaseFileHeader *) records.head->data;
    Assert(hdr->magic == TWOPHASE_MAGIC);
-   hdr->total_len = records.total_len + sizeof(pg_crc32);
+   hdr->total_len = records.total_len + sizeof(pg_crc32c);
 
    /*
     * If the file size exceeds MaxAllocSize, we won't be able to read it in
@@ -1082,7 +1082,7 @@ EndPrepare(GlobalTransaction gxact)
     */
    bogus_crc = ~statefile_crc;
 
-   if ((write(fd, &bogus_crc, sizeof(pg_crc32))) != sizeof(pg_crc32))
+   if ((write(fd, &bogus_crc, sizeof(pg_crc32c))) != sizeof(pg_crc32c))
    {
        CloseTransientFile(fd);
        ereport(ERROR,
@@ -1091,7 +1091,7 @@ EndPrepare(GlobalTransaction gxact)
    }
 
    /* Back up to prepare for rewriting the CRC */
-   if (lseek(fd, -((off_t) sizeof(pg_crc32)), SEEK_CUR) < 0)
+   if (lseek(fd, -((off_t) sizeof(pg_crc32c)), SEEK_CUR) < 0)
    {
        CloseTransientFile(fd);
        ereport(ERROR,
@@ -1135,7 +1135,7 @@ EndPrepare(GlobalTransaction gxact)
    /* If we crash now, we have prepared: WAL replay will fix things */
 
    /* write correct CRC and close file */
-   if ((write(fd, &statefile_crc, sizeof(pg_crc32))) != sizeof(pg_crc32))
+   if ((write(fd, &statefile_crc, sizeof(pg_crc32c))) != sizeof(pg_crc32c))
    {
        CloseTransientFile(fd);
        ereport(ERROR,
@@ -1223,7 +1223,7 @@ ReadTwoPhaseFile(TransactionId xid, bool give_warnings)
    int         fd;
    struct stat stat;
    uint32      crc_offset;
-   pg_crc32    calc_crc,
+   pg_crc32c   calc_crc,
                file_crc;
 
    TwoPhaseFilePath(path, xid);
@@ -1258,14 +1258,14 @@ ReadTwoPhaseFile(TransactionId xid, bool give_warnings)
 
    if (stat.st_size < (MAXALIGN(sizeof(TwoPhaseFileHeader)) +
                        MAXALIGN(sizeof(TwoPhaseRecordOnDisk)) +
-                       sizeof(pg_crc32)) ||
+                       sizeof(pg_crc32c)) ||
        stat.st_size > MaxAllocSize)
    {
        CloseTransientFile(fd);
        return NULL;
    }
 
-   crc_offset = stat.st_size - sizeof(pg_crc32);
+   crc_offset = stat.st_size - sizeof(pg_crc32c);
    if (crc_offset != MAXALIGN(crc_offset))
    {
        CloseTransientFile(fd);
@@ -1302,7 +1302,7 @@ ReadTwoPhaseFile(TransactionId xid, bool give_warnings)
    COMP_CRC32C(calc_crc, buf, crc_offset);
    FIN_CRC32C(calc_crc);
 
-   file_crc = *((pg_crc32 *) (buf + crc_offset));
+   file_crc = *((pg_crc32c *) (buf + crc_offset));
 
    if (!EQ_CRC32C(calc_crc, file_crc))
    {
@@ -1545,7 +1545,7 @@ void
 RecreateTwoPhaseFile(TransactionId xid, void *content, int len)
 {
    char        path[MAXPGPATH];
-   pg_crc32    statefile_crc;
+   pg_crc32c   statefile_crc;
    int         fd;
 
    /* Recompute CRC */
@@ -1572,7 +1572,7 @@ RecreateTwoPhaseFile(TransactionId xid, void *content, int len)
                (errcode_for_file_access(),
                 errmsg("could not write two-phase state file: %m")));
    }
-   if (write(fd, &statefile_crc, sizeof(pg_crc32)) != sizeof(pg_crc32))
+   if (write(fd, &statefile_crc, sizeof(pg_crc32c)) != sizeof(pg_crc32c))
    {
        CloseTransientFile(fd);
        ereport(ERROR,

diff --git a/src/backend/access/transam/xlog.c b/src/backend/access/transam/xlog.c
index 5688268c72d0b83799bd4a7ffce31072b6810187..975eac0c22bb92e68ecae444b7a87e2dc43ab770 100644 (file)
--- a/src/backend/access/transam/xlog.c
+++ b/src/backend/access/transam/xlog.c
@@ -862,7 +862,7 @@ XLogRecPtr
 XLogInsertRecord(XLogRecData *rdata, XLogRecPtr fpw_lsn)
 {
    XLogCtlInsert *Insert = &XLogCtl->Insert;
-   pg_crc32    rdata_crc;
+   pg_crc32c   rdata_crc;
    bool        inserted;
    XLogRecord *rechdr = (XLogRecord *) rdata->data;
    bool        isLogSwitch = (rechdr->xl_rmid == RM_XLOG_ID &&
@@ -4179,7 +4179,7 @@ WriteControlFile(void)
 static void
 ReadControlFile(void)
 {
-   pg_crc32    crc;
+   pg_crc32c   crc;
    int         fd;
 
    /*
@@ -4681,7 +4681,7 @@ BootStrapXLOG(void)
    bool        use_existent;
    uint64      sysidentifier;
    struct timeval tv;
-   pg_crc32    crc;
+   pg_crc32c   crc;
 
    /*
     * Select a hopefully-unique system identifier code for this installation.

diff --git a/src/backend/access/transam/xloginsert.c b/src/backend/access/transam/xloginsert.c
index 88209c3d163211c81fca255f8d18c567b4b44e10..618f8792f894887d2b1ef13e6ae63e5e5a5c1f34 100644 (file)
--- a/src/backend/access/transam/xloginsert.c
+++ b/src/backend/access/transam/xloginsert.c
@@ -459,7 +459,7 @@ XLogRecordAssemble(RmgrId rmid, uint8 info,
    XLogRecData *rdt;
    uint32      total_len = 0;
    int         block_id;
-   pg_crc32    rdata_crc;
+   pg_crc32c   rdata_crc;
    registered_buffer *prev_regbuf = NULL;
    XLogRecData *rdt_datas_last;
    XLogRecord *rechdr;

diff --git a/src/backend/access/transam/xlogreader.c b/src/backend/access/transam/xlogreader.c
index a4124d90d1b60561cdb26a0ffbe5127e63f50cd9..77be1b8ef3c2243a6909a8d9cdb78083fdc7dda5 100644 (file)
--- a/src/backend/access/transam/xlogreader.c
+++ b/src/backend/access/transam/xlogreader.c
@@ -665,7 +665,7 @@ ValidXLogRecordHeader(XLogReaderState *state, XLogRecPtr RecPtr,
 static bool
 ValidXLogRecord(XLogReaderState *state, XLogRecord *record, XLogRecPtr recptr)
 {
-   pg_crc32    crc;
+   pg_crc32c   crc;
 
    /* Calculate the CRC */
    INIT_CRC32C(crc);

diff --git a/src/backend/replication/logical/snapbuild.c b/src/backend/replication/logical/snapbuild.c
index ff5ff265e601a626ff6ee3a2807288f2e41c2c08..82e7d986b42d65f60a22f42c8b114e9324183ac3 100644 (file)
--- a/src/backend/replication/logical/snapbuild.c
+++ b/src/backend/replication/logical/snapbuild.c
@@ -1391,7 +1391,7 @@ typedef struct SnapBuildOnDisk
 
    /* data not covered by checksum */
    uint32      magic;
-   pg_crc32    checksum;
+   pg_crc32c   checksum;
 
    /* data covered by checksum */
 
@@ -1634,7 +1634,7 @@ SnapBuildRestore(SnapBuild *builder, XLogRecPtr lsn)
    char        path[MAXPGPATH];
    Size        sz;
    int         readBytes;
-   pg_crc32    checksum;
+   pg_crc32c   checksum;
 
    /* no point in loading a snapshot if we're already there */
    if (builder->state == SNAPBUILD_CONSISTENT)

diff --git a/src/backend/replication/slot.c b/src/backend/replication/slot.c
index fcd7ba1433a889728927a8a07e3b7365618805f0..16ea80bc3a0467e5f97e06a0128b522e1a98f87b 100644 (file)
--- a/src/backend/replication/slot.c
+++ b/src/backend/replication/slot.c
@@ -56,7 +56,7 @@ typedef struct ReplicationSlotOnDisk
 
    /* data not covered by checksum */
    uint32      magic;
-   pg_crc32    checksum;
+   pg_crc32c   checksum;
 
    /* data covered by checksum */
    uint32      version;
@@ -1075,7 +1075,7 @@ RestoreSlotFromDisk(const char *name)
    int         fd;
    bool        restored = false;
    int         readBytes;
-   pg_crc32    checksum;
+   pg_crc32c   checksum;
 
    /* no need to lock here, no concurrent access allowed yet */
 

diff --git a/src/backend/utils/adt/tsgistidx.c b/src/backend/utils/adt/tsgistidx.c
index 25132be441acf33184d8fc5b9146b2380d85ea6c..0a1e6644dd3892a8777e57a1d8b1a6dc7eca9c67 100644 (file)
--- a/src/backend/utils/adt/tsgistidx.c
+++ b/src/backend/utils/adt/tsgistidx.c
@@ -17,6 +17,7 @@
 #include "access/gist.h"
 #include "access/tuptoaster.h"
 #include "tsearch/ts_utils.h"
+#include "utils/pg_crc.h"
 
 
 #define SIGLENINT  31          /* >121 => key will toast, so it will not work

diff --git a/src/backend/utils/adt/tsquery.c b/src/backend/utils/adt/tsquery.c
index acabd94f08eee6e0557363494523ecacec318c8b..2c32ffe5af777d6873d52106cdd9daca1434abb7 100644 (file)
--- a/src/backend/utils/adt/tsquery.c
+++ b/src/backend/utils/adt/tsquery.c
@@ -14,13 +14,13 @@
 
 #include "postgres.h"
 
-#include "common/pg_crc.h"
 #include "libpq/pqformat.h"
 #include "miscadmin.h"
 #include "tsearch/ts_locale.h"
 #include "tsearch/ts_utils.h"
 #include "utils/builtins.h"
 #include "utils/memutils.h"
+#include "utils/pg_crc.h"
 
 
 struct TSQueryParserStateData

diff --git a/src/backend/utils/cache/relmapper.c b/src/backend/utils/cache/relmapper.c
index 48b83516769eddcdec8b1f0530c4b198c62c5ea6..c151b92dfc3d795aaa9455022512a2ba3479d7eb 100644 (file)
--- a/src/backend/utils/cache/relmapper.c
+++ b/src/backend/utils/cache/relmapper.c
@@ -86,7 +86,7 @@ typedef struct RelMapFile
    int32       magic;          /* always RELMAPPER_FILEMAGIC */
    int32       num_mappings;   /* number of valid RelMapping entries */
    RelMapping  mappings[MAX_MAPPINGS];
-   pg_crc32    crc;            /* CRC of all above */
+   pg_crc32c   crc;            /* CRC of all above */
    int32       pad;            /* to make the struct size be 512 exactly */
 } RelMapFile;
 
@@ -626,7 +626,7 @@ load_relmap_file(bool shared)
 {
    RelMapFile *map;
    char        mapfilename[MAXPGPATH];
-   pg_crc32    crc;
+   pg_crc32c   crc;
    int         fd;
 
    if (shared)

diff --git a/src/backend/utils/hash/Makefile b/src/backend/utils/hash/Makefile
index 05d347c85630176a7414f336ba6cb3d72cba4e4d..64eebd1d996c42ede260726021303b7c029901ac 100644 (file)
--- a/src/backend/utils/hash/Makefile
+++ b/src/backend/utils/hash/Makefile
@@ -12,6 +12,6 @@ subdir = src/backend/utils/hash
 top_builddir = ../../../..
 include $(top_builddir)/src/Makefile.global
 
-OBJS = dynahash.o hashfn.o
+OBJS = dynahash.o hashfn.o pg_crc.o
 
 include $(top_srcdir)/src/backend/common.mk

diff --git a/src/backend/utils/hash/pg_crc.c b/src/backend/utils/hash/pg_crc.c
new file mode 100644 (file)
index 0000000..74c1618
--- /dev/null
+++ b/src/backend/utils/hash/pg_crc.c
@@ -0,0 +1,97 @@
+/*-------------------------------------------------------------------------
+ *
+ * pg_crc.c
+ *   PostgreSQL CRC support
+ *
+ * See Ross Williams' excellent introduction
+ * A PAINLESS GUIDE TO CRC ERROR DETECTION ALGORITHMS, available from
+ * http://www.ross.net/crc/download/crc_v3.txt or several other net sites.
+ *
+ * Portions Copyright (c) 1996-2015, PostgreSQL Global Development Group
+ * Portions Copyright (c) 1994, Regents of the University of California
+ *
+ *
+ * IDENTIFICATION
+ *   src/backend/utils/hash/pg_crc.c
+ *
+ *-------------------------------------------------------------------------
+ */
+
+#include "c.h"
+
+#include "utils/pg_crc.h"
+
+/*
+ * Lookup table for calculating CRC-32 using Sarwate's algorithm.
+ *
+ * This table is based on the polynomial
+ * x^32+x^26+x^23+x^22+x^16+x^12+x^11+x^10+x^8+x^7+x^5+x^4+x^2+x+1.
+ * (This is the same polynomial used in Ethernet checksums, for instance.)
+ * Using Williams' terms, this is the "normal", not "reflected" version.
+ */
+const uint32 pg_crc32_table[256] = {
+   0x00000000, 0x77073096, 0xEE0E612C, 0x990951BA,
+   0x076DC419, 0x706AF48F, 0xE963A535, 0x9E6495A3,
+   0x0EDB8832, 0x79DCB8A4, 0xE0D5E91E, 0x97D2D988,
+   0x09B64C2B, 0x7EB17CBD, 0xE7B82D07, 0x90BF1D91,
+   0x1DB71064, 0x6AB020F2, 0xF3B97148, 0x84BE41DE,
+   0x1ADAD47D, 0x6DDDE4EB, 0xF4D4B551, 0x83D385C7,
+   0x136C9856, 0x646BA8C0, 0xFD62F97A, 0x8A65C9EC,
+   0x14015C4F, 0x63066CD9, 0xFA0F3D63, 0x8D080DF5,
+   0x3B6E20C8, 0x4C69105E, 0xD56041E4, 0xA2677172,
+   0x3C03E4D1, 0x4B04D447, 0xD20D85FD, 0xA50AB56B,
+   0x35B5A8FA, 0x42B2986C, 0xDBBBC9D6, 0xACBCF940,
+   0x32D86CE3, 0x45DF5C75, 0xDCD60DCF, 0xABD13D59,
+   0x26D930AC, 0x51DE003A, 0xC8D75180, 0xBFD06116,
+   0x21B4F4B5, 0x56B3C423, 0xCFBA9599, 0xB8BDA50F,
+   0x2802B89E, 0x5F058808, 0xC60CD9B2, 0xB10BE924,
+   0x2F6F7C87, 0x58684C11, 0xC1611DAB, 0xB6662D3D,
+   0x76DC4190, 0x01DB7106, 0x98D220BC, 0xEFD5102A,
+   0x71B18589, 0x06B6B51F, 0x9FBFE4A5, 0xE8B8D433,
+   0x7807C9A2, 0x0F00F934, 0x9609A88E, 0xE10E9818,
+   0x7F6A0DBB, 0x086D3D2D, 0x91646C97, 0xE6635C01,
+   0x6B6B51F4, 0x1C6C6162, 0x856530D8, 0xF262004E,
+   0x6C0695ED, 0x1B01A57B, 0x8208F4C1, 0xF50FC457,
+   0x65B0D9C6, 0x12B7E950, 0x8BBEB8EA, 0xFCB9887C,
+   0x62DD1DDF, 0x15DA2D49, 0x8CD37CF3, 0xFBD44C65,
+   0x4DB26158, 0x3AB551CE, 0xA3BC0074, 0xD4BB30E2,
+   0x4ADFA541, 0x3DD895D7, 0xA4D1C46D, 0xD3D6F4FB,
+   0x4369E96A, 0x346ED9FC, 0xAD678846, 0xDA60B8D0,
+   0x44042D73, 0x33031DE5, 0xAA0A4C5F, 0xDD0D7CC9,
+   0x5005713C, 0x270241AA, 0xBE0B1010, 0xC90C2086,
+   0x5768B525, 0x206F85B3, 0xB966D409, 0xCE61E49F,
+   0x5EDEF90E, 0x29D9C998, 0xB0D09822, 0xC7D7A8B4,
+   0x59B33D17, 0x2EB40D81, 0xB7BD5C3B, 0xC0BA6CAD,
+   0xEDB88320, 0x9ABFB3B6, 0x03B6E20C, 0x74B1D29A,
+   0xEAD54739, 0x9DD277AF, 0x04DB2615, 0x73DC1683,
+   0xE3630B12, 0x94643B84, 0x0D6D6A3E, 0x7A6A5AA8,
+   0xE40ECF0B, 0x9309FF9D, 0x0A00AE27, 0x7D079EB1,
+   0xF00F9344, 0x8708A3D2, 0x1E01F268, 0x6906C2FE,
+   0xF762575D, 0x806567CB, 0x196C3671, 0x6E6B06E7,
+   0xFED41B76, 0x89D32BE0, 0x10DA7A5A, 0x67DD4ACC,
+   0xF9B9DF6F, 0x8EBEEFF9, 0x17B7BE43, 0x60B08ED5,
+   0xD6D6A3E8, 0xA1D1937E, 0x38D8C2C4, 0x4FDFF252,
+   0xD1BB67F1, 0xA6BC5767, 0x3FB506DD, 0x48B2364B,
+   0xD80D2BDA, 0xAF0A1B4C, 0x36034AF6, 0x41047A60,
+   0xDF60EFC3, 0xA867DF55, 0x316E8EEF, 0x4669BE79,
+   0xCB61B38C, 0xBC66831A, 0x256FD2A0, 0x5268E236,
+   0xCC0C7795, 0xBB0B4703, 0x220216B9, 0x5505262F,
+   0xC5BA3BBE, 0xB2BD0B28, 0x2BB45A92, 0x5CB36A04,
+   0xC2D7FFA7, 0xB5D0CF31, 0x2CD99E8B, 0x5BDEAE1D,
+   0x9B64C2B0, 0xEC63F226, 0x756AA39C, 0x026D930A,
+   0x9C0906A9, 0xEB0E363F, 0x72076785, 0x05005713,
+   0x95BF4A82, 0xE2B87A14, 0x7BB12BAE, 0x0CB61B38,
+   0x92D28E9B, 0xE5D5BE0D, 0x7CDCEFB7, 0x0BDBDF21,
+   0x86D3D2D4, 0xF1D4E242, 0x68DDB3F8, 0x1FDA836E,
+   0x81BE16CD, 0xF6B9265B, 0x6FB077E1, 0x18B74777,
+   0x88085AE6, 0xFF0F6A70, 0x66063BCA, 0x11010B5C,
+   0x8F659EFF, 0xF862AE69, 0x616BFFD3, 0x166CCF45,
+   0xA00AE278, 0xD70DD2EE, 0x4E048354, 0x3903B3C2,
+   0xA7672661, 0xD06016F7, 0x4969474D, 0x3E6E77DB,
+   0xAED16A4A, 0xD9D65ADC, 0x40DF0B66, 0x37D83BF0,
+   0xA9BCAE53, 0xDEBB9EC5, 0x47B2CF7F, 0x30B5FFE9,
+   0xBDBDF21C, 0xCABAC28A, 0x53B39330, 0x24B4A3A6,
+   0xBAD03605, 0xCDD70693, 0x54DE5729, 0x23D967BF,
+   0xB3667A2E, 0xC4614AB8, 0x5D681B02, 0x2A6F2B94,
+   0xB40BBE37, 0xC30C8EA1, 0x5A05DF1B, 0x2D02EF8D
+};

diff --git a/src/bin/pg_controldata/pg_controldata.c b/src/bin/pg_controldata/pg_controldata.c
index a838bb5b2c30dea7db197c8192cd952c9c5b0311..d8cfe5e68dc0ddeefd580138678573a97f084ed2 100644 (file)
--- a/src/bin/pg_controldata/pg_controldata.c
+++ b/src/bin/pg_controldata/pg_controldata.c
@@ -92,7 +92,7 @@ main(int argc, char *argv[])
    int         fd;
    char        ControlFilePath[MAXPGPATH];
    char       *DataDir = NULL;
-   pg_crc32    crc;
+   pg_crc32c   crc;
    time_t      time_tmp;
    char        pgctime_str[128];
    char        ckpttime_str[128];

diff --git a/src/bin/pg_resetxlog/pg_resetxlog.c b/src/bin/pg_resetxlog/pg_resetxlog.c
index 3361111c38077c2cdc8ec389323c4946e31ed47f..a0805d86b048cd9f6e8c0c855687e215e2014614 100644 (file)
--- a/src/bin/pg_resetxlog/pg_resetxlog.c
+++ b/src/bin/pg_resetxlog/pg_resetxlog.c
@@ -465,7 +465,7 @@ ReadControlFile(void)
    int         fd;
    int         len;
    char       *buffer;
-   pg_crc32    crc;
+   pg_crc32c   crc;
 
    if ((fd = open(XLOG_CONTROL_FILE, O_RDONLY | PG_BINARY, 0)) < 0)
    {
@@ -1062,7 +1062,7 @@ WriteEmptyXLOG(void)
    XLogPageHeader page;
    XLogLongPageHeader longpage;
    XLogRecord *record;
-   pg_crc32    crc;
+   pg_crc32c   crc;
    char        path[MAXPGPATH];
    int         fd;
    int         nbytes;

diff --git a/src/bin/pg_rewind/pg_rewind.c b/src/bin/pg_rewind/pg_rewind.c
index 93341a3c8348a5375980030150fb5b143cd0661a..40aa0d3b8ba078466baec7d75f65ce328f90953b 100644 (file)
--- a/src/bin/pg_rewind/pg_rewind.c
+++ b/src/bin/pg_rewind/pg_rewind.c
@@ -508,7 +508,7 @@ createBackupLabel(XLogRecPtr startpoint, TimeLineID starttli, XLogRecPtr checkpo
 static void
 checkControlFile(ControlFileData *ControlFile)
 {
-   pg_crc32    crc;
+   pg_crc32c   crc;
 
    /* Calculate CRC */
    INIT_CRC32C(crc);

diff --git a/src/common/Makefile b/src/common/Makefile
index c2e456d89a25d03e579df5315b541340ce9c9eeb..c47445e768b0f057587317f458164e9c6b61e21c 100644 (file)
--- a/src/common/Makefile
+++ b/src/common/Makefile
@@ -23,7 +23,7 @@ include $(top_builddir)/src/Makefile.global
 override CPPFLAGS := -DFRONTEND $(CPPFLAGS)
 LIBS += $(PTHREAD_LIBS)
 
-OBJS_COMMON = exec.o pg_crc.o pg_lzcompress.o pgfnames.o psprintf.o relpath.o \
+OBJS_COMMON = exec.o pg_lzcompress.o pgfnames.o psprintf.o relpath.o \
    rmtree.o string.o username.o wait_error.o
 
 OBJS_FRONTEND = $(OBJS_COMMON) fe_memutils.o restricted_token.o

diff --git a/src/include/access/xlogrecord.h b/src/include/access/xlogrecord.h
index 09bbcb1488b3dc600b1fc816413e8034ac375b47..b487ae0cc8e1c1084711835bbccfb5ba356258c8 100644 (file)
--- a/src/include/access/xlogrecord.h
+++ b/src/include/access/xlogrecord.h
@@ -13,7 +13,7 @@
 
 #include "access/rmgr.h"
 #include "access/xlogdefs.h"
-#include "common/pg_crc.h"
+#include "port/pg_crc32c.h"
 #include "storage/block.h"
 #include "storage/relfilenode.h"
 
@@ -46,13 +46,13 @@ typedef struct XLogRecord
    uint8       xl_info;        /* flag bits, see below */
    RmgrId      xl_rmid;        /* resource manager for this record */
    /* 2 bytes of padding here, initialize to zero */
-   pg_crc32    xl_crc;         /* CRC for this record */
+   pg_crc32c   xl_crc;         /* CRC for this record */
 
    /* XLogRecordBlockHeaders and XLogRecordDataHeader follow, no padding */
 
 } XLogRecord;
 
-#define SizeOfXLogRecord   (offsetof(XLogRecord, xl_crc) + sizeof(pg_crc32))
+#define SizeOfXLogRecord   (offsetof(XLogRecord, xl_crc) + sizeof(pg_crc32c))
 
 /*
  * The high 4 bits in xl_info may be used freely by rmgr. The

diff --git a/src/include/catalog/pg_control.h b/src/include/catalog/pg_control.h
index 31232b13c5e6d7d86266603764ee30a7e7503642..2e4c3813612e15585d0060261049cce04b2b87fe 100644 (file)
--- a/src/include/catalog/pg_control.h
+++ b/src/include/catalog/pg_control.h
@@ -16,8 +16,8 @@
 #define PG_CONTROL_H
 
 #include "access/xlogdefs.h"
-#include "common/pg_crc.h"
 #include "pgtime.h"                /* for pg_time_t */
+#include "port/pg_crc32c.h"
 
 
 /* Version identifier for this pg_control format */
@@ -224,7 +224,7 @@ typedef struct ControlFileData
    uint32      data_checksum_version;
 
    /* CRC of all above ... MUST BE LAST! */
-   pg_crc32    crc;
+   pg_crc32c   crc;
 } ControlFileData;
 
 /*

diff --git a/src/include/port/pg_crc32c.h b/src/include/port/pg_crc32c.h
new file mode 100644 (file)
index 0000000..d07c0cb
--- /dev/null
+++ b/src/include/port/pg_crc32c.h
@@ -0,0 +1,49 @@
+/*-------------------------------------------------------------------------
+ *
+ * pg_crc32c.h
+ *   Routines for computing CRC-32C checksums.
+ *
+ *
+ * Portions Copyright (c) 1996-2015, PostgreSQL Global Development Group
+ * Portions Copyright (c) 1994, Regents of the University of California
+ *
+ * src/include/port/pg_crc32c.h
+ *
+ *-------------------------------------------------------------------------
+ */
+#ifndef PG_CRC32C_H
+#define PG_CRC32C_H
+
+typedef uint32 pg_crc32c;
+
+#define INIT_CRC32C(crc) ((crc) = 0xFFFFFFFF)
+#define EQ_CRC32C(c1, c2) ((c1) == (c2))
+
+/*
+ * Use slicing-by-8 algorithm.
+ *
+ * On big-endian systems, the intermediate value is kept in reverse byte
+ * order, to avoid byte-swapping during the calculation. FIN_CRC32C reverses
+ * the bytes to the final order.
+ */
+#define COMP_CRC32C(crc, data, len) \
+   ((crc) = pg_comp_crc32c_sb8((crc), (data), (len)))
+#ifdef WORDS_BIGENDIAN
+
+#ifdef HAVE__BUILTIN_BSWAP32
+#define BSWAP32(x) __builtin_bswap32(x)
+#else
+#define BSWAP32(x) (((x << 24) & 0xff000000) | \
+                   ((x << 8) & 0x00ff0000) | \
+                   ((x >> 8) & 0x0000ff00) | \
+                   ((x >> 24) & 0x000000ff))
+#endif
+
+#define FIN_CRC32C(crc) ((crc) = BSWAP32(crc) ^ 0xFFFFFFFF)
+#else
+#define FIN_CRC32C(crc) ((crc) ^= 0xFFFFFFFF)
+#endif
+
+extern pg_crc32c pg_comp_crc32c_sb8(pg_crc32c crc, const void *data, size_t len);
+
+#endif /* PG_CRC32C_H */

diff --git a/src/include/common/pg_crc.h b/src/include/utils/pg_crc.h
similarity index 69%
rename from src/include/common/pg_crc.h
rename to src/include/utils/pg_crc.h
index f496659baf1a16d4b92fbbde72d50165927a8af6..b4efe157f1c134e8ab3cb6e685bb7b4225cd383d 100644 (file)
--- a/src/include/common/pg_crc.h
+++ b/src/include/utils/pg_crc.h
@@ -24,55 +24,18 @@
  * EQ_<variant>(c1, c2)
  *     Check for equality of two CRCs.
  *
+ * The CRC-32C variant is in port/pg_crc32c.h.
+ *
  * Portions Copyright (c) 1996-2015, PostgreSQL Global Development Group
  * Portions Copyright (c) 1994, Regents of the University of California
  *
- * src/include/common/pg_crc.h
+ * src/include/utils/pg_crc.h
  */
 #ifndef PG_CRC_H
 #define PG_CRC_H
 
-/* ugly hack to let this be used in frontend and backend code on Cygwin */
-#ifdef FRONTEND
-#define CRCDLLIMPORT
-#else
-#define CRCDLLIMPORT PGDLLIMPORT
-#endif
-
 typedef uint32 pg_crc32;
 
-#ifdef HAVE__BUILTIN_BSWAP32
-#define BSWAP32(x) __builtin_bswap32(x)
-#else
-#define BSWAP32(x) (((x << 24) & 0xff000000) | \
-                   ((x << 8) & 0x00ff0000) | \
-                   ((x >> 8) & 0x0000ff00) | \
-                   ((x >> 24) & 0x000000ff))
-#endif
-
-/*
- * CRC calculation using the CRC-32C (Castagnoli) polynomial.
- *
- * We use all-ones as the initial register contents and final bit inversion.
- * This is the same algorithm used e.g. in iSCSI. See RFC 3385 for more
- * details on the choice of polynomial.
- *
- * On big-endian systems, the intermediate value is kept in reverse byte
- * order, to avoid byte-swapping during the calculation. FIN_CRC32C reverses
- * the bytes to the final order.
- */
-#define INIT_CRC32C(crc) ((crc) = 0xFFFFFFFF)
-#ifdef WORDS_BIGENDIAN
-#define FIN_CRC32C(crc)    ((crc) = BSWAP32(crc) ^ 0xFFFFFFFF)
-#else
-#define FIN_CRC32C(crc)    ((crc) ^= 0xFFFFFFFF)
-#endif
-#define COMP_CRC32C(crc, data, len)    \
-   ((crc) = pg_comp_crc32c((crc), (data), (len)))
-#define EQ_CRC32C(c1, c2) ((c1) == (c2))
-
-extern pg_crc32 pg_comp_crc32c(pg_crc32 crc, const void *data, size_t len);
-
 /*
  * CRC-32, the same used e.g. in Ethernet.
  *
@@ -135,8 +98,10 @@ do {                                                              \
    } \
 } while (0)
 
-/* Constant tables for CRC-32C and CRC-32 polynomials */
-extern CRCDLLIMPORT const uint32 pg_crc32c_table[8][256];
-extern CRCDLLIMPORT const uint32 pg_crc32_table[256];
+/*
+ * Constant table for the CRC-32 polynomials. The same table is used by both
+ * the normal and traditional variants.
+ */
+extern PGDLLIMPORT const uint32 pg_crc32_table[256];
 
 #endif   /* PG_CRC_H */

diff --git a/src/port/Makefile b/src/port/Makefile
index abc42a222676664b2f76234bf7788a676bd23a1d..d1c9c8a9877179577f2b63bfbcb53ffef1b2bbb9 100644 (file)
--- a/src/port/Makefile
+++ b/src/port/Makefile
@@ -33,7 +33,7 @@ LIBS += $(PTHREAD_LIBS)
 OBJS = $(LIBOBJS) chklocale.o erand48.o inet_net_ntop.o \
    noblock.o path.o pgcheckdir.o pgmkdirp.o pgsleep.o \
    pgstrcasecmp.o pqsignal.o \
-   qsort.o qsort_arg.o quotes.o sprompt.o tar.o thread.o
+   qsort.o qsort_arg.o quotes.o sprompt.o tar.o thread.o pg_crc32c_sb8.o
 
 # foo_srv.o and foo.o are both built from foo.c, but only foo.o has -DFRONTEND
 OBJS_SRV = $(OBJS:%.o=%_srv.o)

diff --git a/src/common/pg_crc.c b/src/port/pg_crc32c_sb8.c
similarity index 92%
rename from src/common/pg_crc.c
rename to src/port/pg_crc32c_sb8.c
index eba32d34919e983e532e2c217fca5fee97fd844c..425c02ca07c3bc699cc510c50c29a78bf43bd336 100644 (file)
--- a/src/common/pg_crc.c
+++ b/src/port/pg_crc32c_sb8.c
@@ -1,25 +1,28 @@
 /*-------------------------------------------------------------------------
  *
- * pg_crc.c
- *   PostgreSQL CRC support
+ * pg_crc32c_sb8.c
+ *   Compute CRC-32C checksum using slicing-by-8 algorithm.
  *
- * See Ross Williams' excellent introduction
- * A PAINLESS GUIDE TO CRC ERROR DETECTION ALGORITHMS, available from
- * http://www.ross.net/crc/download/crc_v3.txt or several other net sites.
+ * Michael E. Kounavis, Frank L. Berry,
+ * "Novel Table Lookup-Based Algorithms for High-Performance CRC
+ * Generation", IEEE Transactions on Computers, vol.57, no. 11,
+ * pp. 1550-1560, November 2008, doi:10.1109/TC.2008.85
  *
  * Portions Copyright (c) 1996-2015, PostgreSQL Global Development Group
  * Portions Copyright (c) 1994, Regents of the University of California
  *
  *
  * IDENTIFICATION
- *   src/common/pg_crc.c
+ *   src/port/pg_crc32c_sb8.c
  *
  *-------------------------------------------------------------------------
  */
 
 #include "c.h"
 
-#include "common/pg_crc.h"
+#include "port/pg_crc32c.h"
+
+static const uint32 pg_crc32c_table[8][256];
 
 /* Accumulate one input byte */
 #ifdef WORDS_BIGENDIAN
@@ -28,18 +31,8 @@
 #define CRC8(x) pg_crc32c_table[0][(crc ^ (x)) & 0xFF] ^ (crc >> 8)
 #endif
 
-/*
- * This function computes a CRC using the slicing-by-8 algorithm, which
- * uses an 8*256 lookup table to operate on eight bytes in parallel and
- * recombine the results.
- *
- * Michael E. Kounavis, Frank L. Berry,
- * "Novel Table Lookup-Based Algorithms for High-Performance CRC
- * Generation", IEEE Transactions on Computers, vol.57, no. 11,
- * pp. 1550-1560, November 2008, doi:10.1109/TC.2008.85
- */
-pg_crc32
-pg_comp_crc32c(pg_crc32 crc, const void *data, size_t len)
+pg_crc32c
+pg_comp_crc32c_sb8(pg_crc32c crc, const void *data, size_t len)
 {
    const unsigned char *p = data;
    const uint32 *p4;
@@ -113,7 +106,7 @@ pg_comp_crc32c(pg_crc32 crc, const void *data, size_t len)
  * order (IOW, the tables are stored in little-endian order even on big-endian
  * systems).
  */
-const uint32 pg_crc32c_table[8][256] = {
+static const uint32 pg_crc32c_table[8][256] = {
 #ifndef WORDS_BIGENDIAN
    {
        0x00000000, 0xF26B8303, 0xE13B70F7, 0x1350F3F4,
@@ -643,7 +636,7 @@ const uint32 pg_crc32c_table[8][256] = {
        0xE54C35A1, 0xAC704886, 0x7734CFEF, 0x3E08B2C8,
        0xC451B7CC, 0x8D6DCAEB, 0x56294D82, 0x1F1530A5
    }
-#else      /* !WORDS_BIGENDIAN */
+#else                          /* !WORDS_BIGENDIAN */
    {
        0x00000000, 0x03836BF2, 0xF7703BE1, 0xF4F35013,
        0x1F979AC7, 0x1C14F135, 0xE8E7A126, 0xEB64CAD4,
@@ -1172,81 +1165,5 @@ const uint32 pg_crc32c_table[8][256] = {
        0xA1354CE5, 0x864870AC, 0xEFCF3477, 0xC8B2083E,
        0xCCB751C4, 0xEBCA6D8D, 0x824D2956, 0xA530151F
    }
-#endif /* WORDS_BIGENDIAN */
-};
-
-
-/*
- * Lookup table for calculating CRC-32 using Sarwate's algorithm.
- *
- * This table is based on the polynomial
- * x^32+x^26+x^23+x^22+x^16+x^12+x^11+x^10+x^8+x^7+x^5+x^4+x^2+x+1.
- * (This is the same polynomial used in Ethernet checksums, for instance.)
- * Using Williams' terms, this is the "normal", not "reflected" version.
- */
-const uint32 pg_crc32_table[256] = {
-   0x00000000, 0x77073096, 0xEE0E612C, 0x990951BA,
-   0x076DC419, 0x706AF48F, 0xE963A535, 0x9E6495A3,
-   0x0EDB8832, 0x79DCB8A4, 0xE0D5E91E, 0x97D2D988,
-   0x09B64C2B, 0x7EB17CBD, 0xE7B82D07, 0x90BF1D91,
-   0x1DB71064, 0x6AB020F2, 0xF3B97148, 0x84BE41DE,
-   0x1ADAD47D, 0x6DDDE4EB, 0xF4D4B551, 0x83D385C7,
-   0x136C9856, 0x646BA8C0, 0xFD62F97A, 0x8A65C9EC,
-   0x14015C4F, 0x63066CD9, 0xFA0F3D63, 0x8D080DF5,
-   0x3B6E20C8, 0x4C69105E, 0xD56041E4, 0xA2677172,
-   0x3C03E4D1, 0x4B04D447, 0xD20D85FD, 0xA50AB56B,
-   0x35B5A8FA, 0x42B2986C, 0xDBBBC9D6, 0xACBCF940,
-   0x32D86CE3, 0x45DF5C75, 0xDCD60DCF, 0xABD13D59,
-   0x26D930AC, 0x51DE003A, 0xC8D75180, 0xBFD06116,
-   0x21B4F4B5, 0x56B3C423, 0xCFBA9599, 0xB8BDA50F,
-   0x2802B89E, 0x5F058808, 0xC60CD9B2, 0xB10BE924,
-   0x2F6F7C87, 0x58684C11, 0xC1611DAB, 0xB6662D3D,
-   0x76DC4190, 0x01DB7106, 0x98D220BC, 0xEFD5102A,
-   0x71B18589, 0x06B6B51F, 0x9FBFE4A5, 0xE8B8D433,
-   0x7807C9A2, 0x0F00F934, 0x9609A88E, 0xE10E9818,
-   0x7F6A0DBB, 0x086D3D2D, 0x91646C97, 0xE6635C01,
-   0x6B6B51F4, 0x1C6C6162, 0x856530D8, 0xF262004E,
-   0x6C0695ED, 0x1B01A57B, 0x8208F4C1, 0xF50FC457,
-   0x65B0D9C6, 0x12B7E950, 0x8BBEB8EA, 0xFCB9887C,
-   0x62DD1DDF, 0x15DA2D49, 0x8CD37CF3, 0xFBD44C65,
-   0x4DB26158, 0x3AB551CE, 0xA3BC0074, 0xD4BB30E2,
-   0x4ADFA541, 0x3DD895D7, 0xA4D1C46D, 0xD3D6F4FB,
-   0x4369E96A, 0x346ED9FC, 0xAD678846, 0xDA60B8D0,
-   0x44042D73, 0x33031DE5, 0xAA0A4C5F, 0xDD0D7CC9,
-   0x5005713C, 0x270241AA, 0xBE0B1010, 0xC90C2086,
-   0x5768B525, 0x206F85B3, 0xB966D409, 0xCE61E49F,
-   0x5EDEF90E, 0x29D9C998, 0xB0D09822, 0xC7D7A8B4,
-   0x59B33D17, 0x2EB40D81, 0xB7BD5C3B, 0xC0BA6CAD,
-   0xEDB88320, 0x9ABFB3B6, 0x03B6E20C, 0x74B1D29A,
-   0xEAD54739, 0x9DD277AF, 0x04DB2615, 0x73DC1683,
-   0xE3630B12, 0x94643B84, 0x0D6D6A3E, 0x7A6A5AA8,
-   0xE40ECF0B, 0x9309FF9D, 0x0A00AE27, 0x7D079EB1,
-   0xF00F9344, 0x8708A3D2, 0x1E01F268, 0x6906C2FE,
-   0xF762575D, 0x806567CB, 0x196C3671, 0x6E6B06E7,
-   0xFED41B76, 0x89D32BE0, 0x10DA7A5A, 0x67DD4ACC,
-   0xF9B9DF6F, 0x8EBEEFF9, 0x17B7BE43, 0x60B08ED5,
-   0xD6D6A3E8, 0xA1D1937E, 0x38D8C2C4, 0x4FDFF252,
-   0xD1BB67F1, 0xA6BC5767, 0x3FB506DD, 0x48B2364B,
-   0xD80D2BDA, 0xAF0A1B4C, 0x36034AF6, 0x41047A60,
-   0xDF60EFC3, 0xA867DF55, 0x316E8EEF, 0x4669BE79,
-   0xCB61B38C, 0xBC66831A, 0x256FD2A0, 0x5268E236,
-   0xCC0C7795, 0xBB0B4703, 0x220216B9, 0x5505262F,
-   0xC5BA3BBE, 0xB2BD0B28, 0x2BB45A92, 0x5CB36A04,
-   0xC2D7FFA7, 0xB5D0CF31, 0x2CD99E8B, 0x5BDEAE1D,
-   0x9B64C2B0, 0xEC63F226, 0x756AA39C, 0x026D930A,
-   0x9C0906A9, 0xEB0E363F, 0x72076785, 0x05005713,
-   0x95BF4A82, 0xE2B87A14, 0x7BB12BAE, 0x0CB61B38,
-   0x92D28E9B, 0xE5D5BE0D, 0x7CDCEFB7, 0x0BDBDF21,
-   0x86D3D2D4, 0xF1D4E242, 0x68DDB3F8, 0x1FDA836E,
-   0x81BE16CD, 0xF6B9265B, 0x6FB077E1, 0x18B74777,
-   0x88085AE6, 0xFF0F6A70, 0x66063BCA, 0x11010B5C,
-   0x8F659EFF, 0xF862AE69, 0x616BFFD3, 0x166CCF45,
-   0xA00AE278, 0xD70DD2EE, 0x4E048354, 0x3903B3C2,
-   0xA7672661, 0xD06016F7, 0x4969474D, 0x3E6E77DB,
-   0xAED16A4A, 0xD9D65ADC, 0x40DF0B66, 0x37D83BF0,
-   0xA9BCAE53, 0xDEBB9EC5, 0x47B2CF7F, 0x30B5FFE9,
-   0xBDBDF21C, 0xCABAC28A, 0x53B39330, 0x24B4A3A6,
-   0xBAD03605, 0xCDD70693, 0x54DE5729, 0x23D967BF,
-   0xB3667A2E, 0xC4614AB8, 0x5D681B02, 0x2A6F2B94,
-   0xB40BBE37, 0xC30C8EA1, 0x5A05DF1B, 0x2D02EF8D
+#endif   /* WORDS_BIGENDIAN */
 };

diff --git a/src/tools/msvc/Mkvcbuild.pm b/src/tools/msvc/Mkvcbuild.pm
index 2e5126b2860b727bb83dcdd32b6584710231761c..b2c0dfbd7b7089f0f12233af19bf0b828c89952e 100644 (file)
--- a/src/tools/msvc/Mkvcbuild.pm
+++ b/src/tools/msvc/Mkvcbuild.pm
@@ -92,12 +92,12 @@ sub mkvcbuild
      pgcheckdir.c pgmkdirp.c pgsleep.c pgstrcasecmp.c pqsignal.c
      mkdtemp.c qsort.c qsort_arg.c quotes.c system.c
      sprompt.c tar.c thread.c getopt.c getopt_long.c dirent.c
-     win32env.c win32error.c win32setlocale.c);
+     win32env.c win32error.c win32setlocale.c pg_crc32c_sb8.c);
 
    push(@pgportfiles, 'rint.c') if ($vsVersion < '12.00');
 
    our @pgcommonallfiles = qw(
-     exec.c pg_crc.c pg_lzcompress.c pgfnames.c psprintf.c relpath.c rmtree.c
+     exec.c pg_lzcompress.c pgfnames.c psprintf.c relpath.c rmtree.c
      string.c username.c wait_error.c);
 
    our @pgcommonfrontendfiles = (@pgcommonallfiles, qw(fe_memutils.c