Improve comments for parallel executor estimation functions.

The previous comment (which was copied as boilerplate from one file
to the next) implied that it was the executor node itself which was
being serialized, but that's not right.  We're not serializing
the executor nodes; we're just allowing them to store some
additional information in DSM.  Adjusts the comment to reflect this.

Discussion: http://postgr.es/m/CA+TgmoaHVinxG=3h6qBAsyV8xaDyQwbzK7YZnYfE8nJFMK1=FA@mail.gmail.com

diff --git a/src/backend/executor/nodeBitmapHeapscan.c b/src/backend/executor/nodeBitmapHeapscan.c
index f7e55e0b45bd54e4f2fcd571147c53b012e53873..6035b4dfd4c1077fc538d2c5e27c689e46c8e216 100644 (file)
--- a/src/backend/executor/nodeBitmapHeapscan.c
+++ b/src/backend/executor/nodeBitmapHeapscan.c
@@ -934,7 +934,8 @@ BitmapShouldInitializeSharedState(ParallelBitmapHeapState *pstate)
 /* ----------------------------------------------------------------
  *     ExecBitmapHeapEstimate
  *
- *     estimates the space required to serialize bitmap scan node.
+ *     Compute the amount of space we'll need in the parallel
+ *     query DSM, and inform pcxt->estimator about our needs.
  * ----------------------------------------------------------------
  */
 void

diff --git a/src/backend/executor/nodeIndexonlyscan.c b/src/backend/executor/nodeIndexonlyscan.c
index 5351cb8981e11293a63532710dd2404433030857..9368ca04f847c565de7d6fd65f47d858f6d019ed 100644 (file)
--- a/src/backend/executor/nodeIndexonlyscan.c
+++ b/src/backend/executor/nodeIndexonlyscan.c
@@ -604,7 +604,8 @@ ExecInitIndexOnlyScan(IndexOnlyScan *node, EState *estate, int eflags)
 /* ----------------------------------------------------------------
  *     ExecIndexOnlyScanEstimate
  *
- * estimates the space required to serialize index-only scan node.
+ *     Compute the amount of space we'll need in the parallel
+ *     query DSM, and inform pcxt->estimator about our needs.
  * ----------------------------------------------------------------
  */
 void

diff --git a/src/backend/executor/nodeIndexscan.c b/src/backend/executor/nodeIndexscan.c
index 638b17b07cbd9e7e6f5768e6ea691cdba30f22fb..262008240dbb464256e82d825174a09677f74035 100644 (file)
--- a/src/backend/executor/nodeIndexscan.c
+++ b/src/backend/executor/nodeIndexscan.c
@@ -1644,7 +1644,8 @@ ExecIndexBuildScanKeys(PlanState *planstate, Relation index,
 /* ----------------------------------------------------------------
  *     ExecIndexScanEstimate
  *
- *     estimates the space required to serialize indexscan node.
+ *     Compute the amount of space we'll need in the parallel
+ *     query DSM, and inform pcxt->estimator about our needs.
  * ----------------------------------------------------------------
  */
 void

diff --git a/src/backend/executor/nodeSeqscan.c b/src/backend/executor/nodeSeqscan.c
index d4ac939c9b068785a8fe4ac7990af8fec1aeb587..76bec780a8d25d635fe77b35f8ab398187089591 100644 (file)
--- a/src/backend/executor/nodeSeqscan.c
+++ b/src/backend/executor/nodeSeqscan.c
@@ -289,7 +289,8 @@ ExecReScanSeqScan(SeqScanState *node)
 /* ----------------------------------------------------------------
  *     ExecSeqScanEstimate
  *
- *     estimates the space required to serialize seqscan node.
+ *     Compute the amount of space we'll need in the parallel
+ *     query DSM, and inform pcxt->estimator about our needs.
  * ----------------------------------------------------------------
  */
 void