Simplify useless 0L constants

In ancient times, these belonged to arguments or fields that were
actually of type long, but now they are not anymore, so this "L"
decoration is just confusing.  (Some other 0L and other "L" constants
remain, where they are actually associated with a long type.)

diff --git a/src/backend/access/transam/xlogarchive.c b/src/backend/access/transam/xlogarchive.c
index fcc87ff44fd26f02a43fea0d98d48ca3c084aa07..a0f5aa24b58a9dbefb52e40944969eae915812f8 100644 (file)
--- a/src/backend/access/transam/xlogarchive.c
+++ b/src/backend/access/transam/xlogarchive.c
@@ -148,7 +148,7 @@ RestoreArchivedFile(char *path, const char *xlogfname,
        Assert(strcmp(lastRestartPointFname, xlogfname) <= 0);
    }
    else
-       XLogFileName(lastRestartPointFname, 0, 0L, wal_segment_size);
+       XLogFileName(lastRestartPointFname, 0, 0, wal_segment_size);
 
    /* Build the restore command to execute */
    xlogRestoreCmd = BuildRestoreCommand(recoveryRestoreCommand,

diff --git a/src/backend/backup/backup_manifest.c b/src/backend/backup/backup_manifest.c
index fabd2ca2992e677c540a2f6b4c9e0f35dec5ce89..cee62165246bfdadf9a430e919552f94f7fb30e0 100644 (file)
--- a/src/backend/backup/backup_manifest.c
+++ b/src/backend/backup/backup_manifest.c
@@ -349,7 +349,7 @@ SendBackupManifest(backup_manifest_info *manifest, bbsink *sink)
     * We've written all the data to the manifest file.  Rewind the file so
     * that we can read it all back.
     */
-   if (BufFileSeek(manifest->buffile, 0, 0L, SEEK_SET))
+   if (BufFileSeek(manifest->buffile, 0, 0, SEEK_SET))
        ereport(ERROR,
                (errcode_for_file_access(),
                 errmsg("could not rewind temporary file")));

diff --git a/src/backend/commands/copyto.c b/src/backend/commands/copyto.c
index beea1ac687c10c4cd023e1d36c8d46591bc89c92..9e4b2437a572a5f0d84f7ba2dedf4c8b38b6771f 100644 (file)
--- a/src/backend/commands/copyto.c
+++ b/src/backend/commands/copyto.c
@@ -883,7 +883,7 @@ DoCopyTo(CopyToState cstate)
    else
    {
        /* run the plan --- the dest receiver will send tuples */
-       ExecutorRun(cstate->queryDesc, ForwardScanDirection, 0L, true);
+       ExecutorRun(cstate->queryDesc, ForwardScanDirection, 0, true);
        processed = ((DR_copy *) cstate->queryDesc->dest)->processed;
    }
 

diff --git a/src/backend/commands/createas.c b/src/backend/commands/createas.c
index d6c6d514f300cf7be9ae6cae84fbae0d31eebb8b..e91920ca14a12b3beb26b554f21c2a96e1196cd4 100644 (file)
--- a/src/backend/commands/createas.c
+++ b/src/backend/commands/createas.c
@@ -333,7 +333,7 @@ ExecCreateTableAs(ParseState *pstate, CreateTableAsStmt *stmt,
        ExecutorStart(queryDesc, GetIntoRelEFlags(into));
 
        /* run the plan to completion */
-       ExecutorRun(queryDesc, ForwardScanDirection, 0L, true);
+       ExecutorRun(queryDesc, ForwardScanDirection, 0, true);
 
        /* save the rowcount if we're given a qc to fill */
        if (qc)

diff --git a/src/backend/commands/explain.c b/src/backend/commands/explain.c
index 878d2fd172c17da41d7552a61888f07e04309a13..7e48e9c210143db2cdee4749c6f3d9139ef06b8c 100644 (file)
--- a/src/backend/commands/explain.c
+++ b/src/backend/commands/explain.c
@@ -601,7 +601,7 @@ ExplainOnePlan(PlannedStmt *plannedstmt, IntoClause *into, ExplainState *es,
            dir = ForwardScanDirection;
 
        /* run the plan */
-       ExecutorRun(queryDesc, dir, 0L, true);
+       ExecutorRun(queryDesc, dir, 0, true);
 
        /* run cleanup too */
        ExecutorFinish(queryDesc);

diff --git a/src/backend/commands/matview.c b/src/backend/commands/matview.c
index c00b9df3e3bcb1c13ee4f11593d2ad1118c271de..f9a3bdfc3abbff2bc2ad5d78252d5f91f3967a67 100644 (file)
--- a/src/backend/commands/matview.c
+++ b/src/backend/commands/matview.c
@@ -417,7 +417,7 @@ refresh_matview_datafill(DestReceiver *dest, Query *query,
    ExecutorStart(queryDesc, 0);
 
    /* run the plan */
-   ExecutorRun(queryDesc, ForwardScanDirection, 0L, true);
+   ExecutorRun(queryDesc, ForwardScanDirection, 0, true);
 
    processed = queryDesc->estate->es_processed;
 

diff --git a/src/backend/commands/portalcmds.c b/src/backend/commands/portalcmds.c
index 8a3cf98cce7e35224b17bf361c5725b756dbd76f..73ed7aa2f0ad4d8649260279c2d375f66d5909cd 100644 (file)
--- a/src/backend/commands/portalcmds.c
+++ b/src/backend/commands/portalcmds.c
@@ -417,7 +417,7 @@ PersistHoldablePortal(Portal portal)
                                        NULL);
 
        /* Fetch the result set into the tuplestore */
-       ExecutorRun(queryDesc, direction, 0L, false);
+       ExecutorRun(queryDesc, direction, 0, false);
 
        queryDesc->dest->rDestroy(queryDesc->dest);
        queryDesc->dest = NULL;

diff --git a/src/backend/executor/nodeHashjoin.c b/src/backend/executor/nodeHashjoin.c
index f189fb4d2873c3c103d3f59951f30eca5c07e7a9..2fc80808e30197b6ace81b9d364e994bc4f9184a 100644 (file)
--- a/src/backend/executor/nodeHashjoin.c
+++ b/src/backend/executor/nodeHashjoin.c
@@ -1072,7 +1072,7 @@ ExecHashJoinNewBatch(HashJoinState *hjstate)
 
    if (innerFile != NULL)
    {
-       if (BufFileSeek(innerFile, 0, 0L, SEEK_SET))
+       if (BufFileSeek(innerFile, 0, 0, SEEK_SET))
            ereport(ERROR,
                    (errcode_for_file_access(),
                     errmsg("could not rewind hash-join temporary file")));
@@ -1102,7 +1102,7 @@ ExecHashJoinNewBatch(HashJoinState *hjstate)
     */
    if (hashtable->outerBatchFile[curbatch] != NULL)
    {
-       if (BufFileSeek(hashtable->outerBatchFile[curbatch], 0, 0L, SEEK_SET))
+       if (BufFileSeek(hashtable->outerBatchFile[curbatch], 0, 0, SEEK_SET))
            ereport(ERROR,
                    (errcode_for_file_access(),
                     errmsg("could not rewind hash-join temporary file")));

diff --git a/src/backend/storage/file/buffile.c b/src/backend/storage/file/buffile.c
index 0a51624df3b31ba5614716210846b82b9b9adfe0..1a1b3335bd24b03cf8ba5effe4b12fbf288c706a 100644 (file)
--- a/src/backend/storage/file/buffile.c
+++ b/src/backend/storage/file/buffile.c
@@ -119,7 +119,7 @@ makeBufFileCommon(int nfiles)
    file->dirty = false;
    file->resowner = CurrentResourceOwner;
    file->curFile = 0;
-   file->curOffset = 0L;
+   file->curOffset = 0;
    file->pos = 0;
    file->nbytes = 0;
 
@@ -439,7 +439,7 @@ BufFileLoadBuffer(BufFile *file)
        file->curFile + 1 < file->numFiles)
    {
        file->curFile++;
-       file->curOffset = 0L;
+       file->curOffset = 0;
    }
 
    thisfile = file->files[file->curFile];
@@ -511,7 +511,7 @@ BufFileDumpBuffer(BufFile *file)
            while (file->curFile + 1 >= file->numFiles)
                extendBufFile(file);
            file->curFile++;
-           file->curOffset = 0L;
+           file->curOffset = 0;
        }
 
        /*

diff --git a/src/backend/tcop/pquery.c b/src/backend/tcop/pquery.c
index 5f0248acc59c29dd0049c963b60252251b74e8e5..5565f200c3dd6c5380b5bec80ad36e169a49388a 100644 (file)
--- a/src/backend/tcop/pquery.c
+++ b/src/backend/tcop/pquery.c
@@ -157,7 +157,7 @@ ProcessQuery(PlannedStmt *plan,
    /*
     * Run the plan to completion.
     */
-   ExecutorRun(queryDesc, ForwardScanDirection, 0L, true);
+   ExecutorRun(queryDesc, ForwardScanDirection, 0, true);
 
    /*
     * Build command completion status data, if caller wants one.

diff --git a/src/backend/utils/sort/tuplestore.c b/src/backend/utils/sort/tuplestore.c
index bc36662198a51a904c97ba359669c85a5b1908c0..f60633df241b00cb52048c7255f47b042e5d1fbc 100644 (file)
--- a/src/backend/utils/sort/tuplestore.c
+++ b/src/backend/utils/sort/tuplestore.c
@@ -1246,11 +1246,11 @@ tuplestore_rescan(Tuplestorestate *state)
        case TSS_WRITEFILE:
            readptr->eof_reached = false;
            readptr->file = 0;
-           readptr->offset = 0L;
+           readptr->offset = 0;
            break;
        case TSS_READFILE:
            readptr->eof_reached = false;
-           if (BufFileSeek(state->myfile, 0, 0L, SEEK_SET) != 0)
+           if (BufFileSeek(state->myfile, 0, 0, SEEK_SET) != 0)
                ereport(ERROR,
                        (errcode_for_file_access(),
                         errmsg("could not seek in tuplestore temporary file")));