Fix COPY FROM when database encoding is SQL_ASCII.
authorHeikki Linnakangas <heikki.linnakangas@iki.fi>
Sun, 29 May 2022 20:53:45 +0000 (23:53 +0300)
committerHeikki Linnakangas <heikki.linnakangas@iki.fi>
Sun, 29 May 2022 20:54:25 +0000 (23:54 +0300)
commitfc36ac52ebd3b0c879877c424f94318728b25935
tree9fa4bc9c53f3672223c97e2e0fd620d5405b2ccf
parentf6b6a8fb94f115c5197fbba0c004a262dc710134
Fix COPY FROM when database encoding is SQL_ASCII.

In the codepath when no encoding conversion is required, the check for
incomplete character at the end of input incorrectly used server
encoding's max character length, instead of the client's. Usually the
server and client encodings are the same when we're not performing
encoding conversion, but SQL_ASCII is an exception.

In the passing, also fix some outdated comments that still talked about
the old COPY protocol. It was removed in v14.

Per bug #17501 from Vitaly Voronov. Backpatch to v14 where this was
introduced.

Discussion: https://www.postgresql.org/message-id/17501-128b1dd039362ae6@postgresql.org
src/backend/commands/copyfromparse.c