Disallow SRFs when considering sorts below Gather Merge
authorTomas Vondra <tomas.vondra@postgresql.org>
Mon, 21 Dec 2020 17:58:32 +0000 (18:58 +0100)
committerTomas Vondra <tomas.vondra@postgresql.org>
Mon, 21 Dec 2020 18:36:22 +0000 (19:36 +0100)
commitfac1b470a9f7e846534620b78ea4cf122ed432b2
tree1f744e28fef69e808d099b04d4abc6d2779f7285
parentff5d5611c01f60525c30b2c3ebc16d05edb7956d
Disallow SRFs when considering sorts below Gather Merge

While we do allow SRFs in ORDER BY, scan/join processing should not
consider such cases - such sorts should only happen via final Sort atop
a ProjectSet. So make sure we don't try adding such sorts below Gather
Merge, just like we do for expressions that are volatile and/or not
parallel safe.

Backpatch to PostgreSQL 13, where this code was introduced as part of
the Incremental Sort patch.

Author: James Coleman
Reviewed-by: Tomas Vondra
Backpatch-through: 13
Discussion: https://postgr.es/m/CAAaqYe8cK3g5CfLC4w7bs=hC0mSksZC=H5M8LSchj5e5OxpTAg@mail.gmail.com
Discussion: https://postgr.es/m/295524.1606246314%40sss.pgh.pa.us
src/backend/optimizer/path/equivclass.c
src/backend/optimizer/util/tlist.c
src/include/optimizer/optimizer.h
src/test/regress/expected/incremental_sort.out
src/test/regress/sql/incremental_sort.sql