Disconnect if socket cannot be put into non-blocking mode
authorHeikki Linnakangas <heikki.linnakangas@iki.fi>
Tue, 12 Mar 2024 08:18:32 +0000 (10:18 +0200)
committerHeikki Linnakangas <heikki.linnakangas@iki.fi>
Tue, 12 Mar 2024 08:18:32 +0000 (10:18 +0200)
commitf8c5317d001556a51441fad81e8f6c32994f2d79
tree53674c785ba7f1b7f12d3e2ca0959984eeea9855
parent4dec98c2af64851b643af14c36c8b99215dfd70d
Disconnect if socket cannot be put into non-blocking mode

Commit 387da18874 moved the code to put socket into non-blocking mode
from socket_set_nonblocking() into the one-time initialization
function, pq_init(). In socket_set_nonblocking(), there indeed was a
risk of recursion on failure like the comment said, but in pq_init(),
ERROR or FATAL is fine. There's even another elog(FATAL) just after
this, if setting FD_CLOEXEC fails.

Note that COMMERROR merely logged the error, it did not close the
connection, so if putting the socket to non-blocking mode failed we
would use the connection anyway. You might not immediately notice,
because most socket operations in a regular backend wait for the
socket to become readable/writable anyway. But e.g. replication will
be quite broken.

Backpatch to all supported versions.

Discussion: https://www.postgresql.org/message-id/d40a5cd0-2722-40c5-8755-12e9e811fa3c@iki.fi
src/backend/libpq/pqcomm.c