Fix wal_consistency_checking nbtree bug.
authorPeter Geoghegan <pg@bowt.ie>
Thu, 5 Nov 2020 23:01:40 +0000 (15:01 -0800)
committerPeter Geoghegan <pg@bowt.ie>
Thu, 5 Nov 2020 23:01:40 +0000 (15:01 -0800)
commitefc5dcfd8ad4e1df633025d8a91b64cd44d93f42
treefac838f9b88f4ae1b6dd3dcf50d91e6509b19551
parent5b7bfc39726ff9f6c52dd73e337c34e74e0d1f39
Fix wal_consistency_checking nbtree bug.

wal_consistency_checking indicated an inconsistency in certain cases
involving nbtree page deletion.  The underlying issue is that there was
a minor difference between the page image produced after a REDO routine
ran and the corresponding page image following original execution.

This harmless inconsistency has been around forever.  We more or less
expect total consistency among even deleted nbtree pages these days,
though, so this won't do anymore.

To fix, tweak the REDO routine to match original execution.

Oversight in commit f47b5e13.
src/backend/access/nbtree/nbtxlog.c