Fix get_useful_pathkeys_for_relation for volatile expressions
authorTomas Vondra <tomas.vondra@postgresql.org>
Tue, 3 Nov 2020 19:07:23 +0000 (20:07 +0100)
committerTomas Vondra <tomas.vondra@postgresql.org>
Tue, 3 Nov 2020 21:31:57 +0000 (22:31 +0100)
commitebb7ae839d033d0f279670e249f54646a08b8c48
tree96921a9a470206f6df84d4072f6d0fc2dc18b7fe
parent92f87182f2c617fd420832972b6d0ae4527301c8
Fix get_useful_pathkeys_for_relation for volatile expressions

When considering Incremental Sort below a Gather Merge, we need to be
a bit more careful when matching pathkeys to EC members. It's not enough
to find a member whose Vars are all in the current relation's target;
volatile expressions in particular need to be contained in the target,
otherwise it's too early to use the pathkey.

Reported-by: Jaime Casanova
Author: James Coleman
Reviewed-by: Tomas Vondra
Backpatch-through: 13, where the incremental sort code was added
Discussion: https://postgr.es/m/CAJGNTeNaxpXgBVcRhJX%2B2vSbq%2BF2kJqGBcvompmpvXb7pq%2BoFA%40mail.gmail.com
src/backend/optimizer/path/allpaths.c
src/backend/optimizer/path/equivclass.c
src/include/optimizer/paths.h
src/test/regress/expected/incremental_sort.out
src/test/regress/sql/incremental_sort.sql