Sanitize IF NOT EXISTS in EXPLAIN for CTAS and matviews
authorMichael Paquier <michael@paquier.xyz>
Wed, 30 Dec 2020 12:23:24 +0000 (21:23 +0900)
committerMichael Paquier <michael@paquier.xyz>
Wed, 30 Dec 2020 12:23:24 +0000 (21:23 +0900)
commite665769e6d1e84b6650f53ed297058fc11152f7f
tree82a4f55f692707741f6397cedeb8e02894ac69aa
parent0aa8a01d04c8fe200b7a106878eebc3d0af9105c
Sanitize IF NOT EXISTS in EXPLAIN for CTAS and matviews

IF NOT EXISTS was ignored when specified in an EXPLAIN query for CREATE
MATERIALIZED VIEW or CREATE TABLE AS.  Hence, if this clause was
specified, the caller would get a failure if the relation already
exists instead of a success with a NOTICE message.

This commit makes the behavior of IF NOT EXISTS in EXPLAIN consistent
with the non-EXPLAIN'd DDL queries, preventing a failure with IF NOT
EXISTS if the relation to-be-created already exists.  The skip is done
before the SELECT query used for the relation is planned or executed,
and a "dummy" plan is generated instead depending on the format used by
EXPLAIN.

Author: Bharath Rupireddy
Reviewed-by: Zhijie Hou, Michael Paquier
Discussion: https://postgr.es/m/CALj2ACVa3oJ9O_wcGd+FtHWZds04dEKcakxphGz5POVgD4wC7Q@mail.gmail.com
src/backend/commands/createas.c
src/backend/commands/explain.c
src/include/commands/createas.h
src/test/regress/expected/matview.out
src/test/regress/expected/select_into.out
src/test/regress/sql/matview.sql
src/test/regress/sql/select_into.sql