Invent qsort_interruptible().
authorTom Lane <tgl@sss.pgh.pa.us>
Tue, 12 Jul 2022 20:30:36 +0000 (16:30 -0400)
committerTom Lane <tgl@sss.pgh.pa.us>
Tue, 12 Jul 2022 20:30:36 +0000 (16:30 -0400)
commite64cdab003027acef29e713087fb667e2319f679
tree70f558736a70f872f201e278bd4400ba8c1d2b15
parent920072339f304a7da0b5de966117420c96ad78cb
Invent qsort_interruptible().

Justin Pryzby reported that some scenarios could cause gathering
of extended statistics to spend many seconds in an un-cancelable
qsort() operation.  To fix, invent qsort_interruptible(), which is
just like qsort_arg() except that it will also do CHECK_FOR_INTERRUPTS
every so often.  This bloats the backend by a couple of kB, which
seems like a good investment.  (We considered just enabling
CHECK_FOR_INTERRUPTS in the existing qsort and qsort_arg functions,
but there are some callers for which that'd demonstrably be unsafe.
Opt-in seems like a better way.)

For now, just apply qsort_interruptible() in statistics collection.
There's probably more places where it could be useful, but we can
always change other call sites as we find problems.

Back-patch to v14.  Before that we didn't have extended stats on
expressions, so that the problem was less severe.  Also, this patch
depends on the sort_template infrastructure introduced in v14.

Tom Lane and Justin Pryzby

Discussion: https://postgr.es/m/20220509000108.GQ28830@telsasoft.com
src/backend/commands/analyze.c
src/backend/statistics/extended_stats.c
src/backend/statistics/mcv.c
src/backend/statistics/mvdistinct.c
src/backend/tsearch/ts_typanalyze.c
src/backend/utils/adt/array_typanalyze.c
src/backend/utils/adt/rangetypes_typanalyze.c
src/backend/utils/sort/Makefile
src/backend/utils/sort/qsort_interruptible.c [new file with mode: 0644]
src/include/port.h