Fix assert in logicalmsg_desc
authorTomas Vondra <tomas.vondra@postgresql.org>
Tue, 16 Aug 2022 21:52:10 +0000 (23:52 +0200)
committerTomas Vondra <tomas.vondra@postgresql.org>
Tue, 16 Aug 2022 21:52:10 +0000 (23:52 +0200)
commitc52ad9c4efdb91ce274c65b1acdb350e439c7b2d
tree68c78cf4b64421c10da900b918650d340ad50f20
parent40ca9073ff228163b1320122a82e4064da6cf54f
Fix assert in logicalmsg_desc

The assert, introduced by 9f1cf97bb5, is intended to check if the prefix
is terminated by a \0 byte, but it has two flaws. Firstly, prefix_size
includes the \0 byte, so prefix[prefix_size] points to the byte after
the null byte. Secondly, the check ensures the byte is not equal \0,
while it should be checking the opposite.

Backpatch-through: 14
Discussion: https://postgr.es/m/b99b6101-2f14-3796-3dfa-4a6cd7d4326d@enterprisedb.com
src/backend/access/rmgrdesc/logicalmsgdesc.c