Fix calculation of PREDICATELOCK_MANAGER_LWLOCK_OFFSET.
authorKevin Grittner <kgrittn@postgresql.org>
Thu, 19 Jun 2014 13:40:37 +0000 (08:40 -0500)
committerKevin Grittner <kgrittn@postgresql.org>
Thu, 19 Jun 2014 13:40:37 +0000 (08:40 -0500)
commitbfaa8c665fcbd4388e01c53c4b5137f1f53d1787
tree07379e9062322edc065b9e6243ba7f46868c3fd6
parent9ba78fb0b9e6c5a7115592c2c3116fca16b5184e
Fix calculation of PREDICATELOCK_MANAGER_LWLOCK_OFFSET.

Commit ea9df812d8502fff74e7bc37d61bdc7d66d77a7f failed to include
NUM_BUFFER_PARTITIONS in this offset, resulting in a bad offset.
Ultimately this threw off NUM_FIXED_LWLOCKS which is based on
earlier offsets, leading to memory allocation problems.  It seems
likely to have also caused increased LWLOCK contention when
serializable transactions were used, because lightweight locks used
for that overlapped others.

Reported by Amit Kapila with analysis and fix.
Backpatch to 9.4, where the bug was introduced.
src/include/storage/lwlock.h