Fix error handling in libpqrcv_connect()
authorAndres Freund <andres@anarazel.de>
Tue, 24 Jan 2023 02:04:02 +0000 (18:04 -0800)
committerAndres Freund <andres@anarazel.de>
Tue, 24 Jan 2023 02:27:42 +0000 (18:27 -0800)
commitbc54ef4ec25a3c642f1706a49f979b7750a2817e
treef351188c033dab34c97da6f3e1374e44031a06d1
parent9567686ec834e50ab10ae872a8394c9a9e590b0d
Fix error handling in libpqrcv_connect()

When libpqrcv_connect (also known as walrcv_connect()) failed, it leaked the
libpq connection. In most paths that's fairly harmless, as the calling process
will exit soon after. But e.g. CREATE SUBSCRIPTION could lead to a somewhat
longer lived leak.

Fix by releasing resources, including the libpq connection, on error.

Add a test exercising the error code path. To make it reliable and safe, the
test tries to connect to port=-1, which happens to fail during connection
establishment, rather than during connection string parsing.

Reviewed-by: Noah Misch <noah@leadboat.com>
Discussion: https://postgr.es/m/20230121011237.q52apbvlarfv6jm6@awork3.anarazel.de
Backpatch: 11-
src/backend/replication/libpqwalreceiver/libpqwalreceiver.c
src/test/regress/expected/subscription.out
src/test/regress/sql/subscription.sql