Fix ALTER TABLE .. ADD COLUMN with complex inheritance trees
authorMichael Paquier <michael@paquier.xyz>
Wed, 24 Jan 2024 05:20:01 +0000 (14:20 +0900)
committerMichael Paquier <michael@paquier.xyz>
Wed, 24 Jan 2024 05:20:01 +0000 (14:20 +0900)
commitbb812ab0917e153f11bf449d7cb996815c07e387
tree77f88f3109627a74ccaf6e64738589f054c44984
parentbcd5b4bcbefc8b99be3678cf9c6c990a0c28f68e
Fix ALTER TABLE .. ADD COLUMN with complex inheritance trees

This command, when used to add a column on a parent table with a complex
inheritance tree, tried to update multiple times the same tuple in
pg_attribute for a child table when incrementing attinhcount, causing
failures with "tuple already updated by self" because of a missing
CommandCounterIncrement() between two updates.

This exists for a rather long time, so backpatch all the way down.

Reported-by: Alexander Lakhin
Author: Tender Wang
Reviewed-by: Richard Guo
Discussion: https://postgr.es/m/18297-b04cd83a55b51e35@postgresql.org
Backpatch-through: 12
src/backend/commands/tablecmds.c
src/test/regress/expected/inherit.out
src/test/regress/sql/inherit.sql