Release lock on heap buffer before vacuuming FSM
authorAndres Freund <andres@anarazel.de>
Fri, 17 Nov 2023 19:02:52 +0000 (11:02 -0800)
committerAndres Freund <andres@anarazel.de>
Fri, 17 Nov 2023 20:46:55 +0000 (12:46 -0800)
commitb2e237afddc56a4826121169a693412d8683d940
tree9aad78eabab778c5d7b3e8be639ccfffd1380d22
parentf7816aec23eed1dc1da5f9a53cb6507d30b7f0a2
Release lock on heap buffer before vacuuming FSM

When there are no indexes on a table, we vacuum each heap block after
pruning it and then update the freespace map. Periodically, we also
vacuum the freespace map. This was done while unnecessarily holding a
lock on the heap page. Release the lock before calling
FreeSpaceMapVacuumRange() and, while we're at it, ensure the range
includes the heap block we just vacuumed.

There are no known deadlocks or other similar issues, therefore don't
backpatch. It's certainly not good to do all this work under a lock, but it's
not frequently reached, making it not worth the risk of backpatching.

Author: Melanie Plageman <melanieplageman@gmail.com>
Reviewed-by: Andres Freund <andres@anarazel.de>
Discussion: https://postgr.es/m/CAAKRu_YiL%3D44GvGnt1dpYouDSSoV7wzxVoXs8m3p311rp-TVQQ%40mail.gmail.com
src/backend/access/heap/vacuumlazy.c