Move privilege check to the right place
authorAlvaro Herrera <alvherre@alvh.no-ip.org>
Thu, 7 Sep 2023 10:15:18 +0000 (12:15 +0200)
committerAlvaro Herrera <alvherre@alvh.no-ip.org>
Thu, 7 Sep 2023 10:15:18 +0000 (12:15 +0200)
commitac22a9545ca906e70a819b54e76de38817c93aaf
treeb35b9daf142e921ab878a78f42b9776c7f368f10
parent3af7217942722369a6eb7629e0fb1cbbef889a9b
Move privilege check to the right place

Now that ATExecDropConstraint doesn't recurse anymore, so it's wrong to
test privileges "during recursion" there.  Move the check to
dropconstraint_internal, which is the place where recursion occurs.

In passing, remove now-useless 'recursing' argument to
ATExecDropConstraint.

Discussion: https://postgr.es/m/202309051744.y4mndw5gwzhh@alvherre.pgsql
src/backend/commands/tablecmds.c
src/test/regress/expected/inherit.out
src/test/regress/sql/inherit.sql