Separate vacuum cost variables from GUCs
authorDaniel Gustafsson <dgustafsson@postgresql.org>
Thu, 6 Apr 2023 22:54:53 +0000 (00:54 +0200)
committerDaniel Gustafsson <dgustafsson@postgresql.org>
Thu, 6 Apr 2023 22:54:53 +0000 (00:54 +0200)
commita85c60a945acfcb1aaac0c521e5eb5a2477d9695
tree9408012c24f02a7dbc298f35f2c53335d5a5ca77
parent71a825194fd3f8c084f63bd2b0a8d11d753d25d3
Separate vacuum cost variables from GUCs

Vacuum code run both by autovacuum workers and a backend doing
VACUUM/ANALYZE previously inspected VacuumCostLimit and VacuumCostDelay,
which are the global variables backing the GUCs vacuum_cost_limit and
vacuum_cost_delay.

Autovacuum workers needed to override these variables with their
own values, derived from autovacuum_vacuum_cost_limit and
autovacuum_vacuum_cost_delay and worker cost limit balancing logic.
This led to confusing code which, in some cases, both derived and
set a new value of VacuumCostLimit from VacuumCostLimit.

In preparation for refreshing these GUC values more often, introduce
new, independent global variables and add a function to update them
using the GUCs and existing logic.

Per suggestion by Kyotaro Horiguchi

Author: Melanie Plageman <melanieplageman@gmail.com>
Reviewed-by: Masahiko Sawada <sawada.mshk@gmail.com>
Reviewed-by: Daniel Gustafsson <daniel@yesql.se>
Reviewed-by: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
Reviewed-by: Robert Haas <robertmhaas@gmail.com>
Discussion: https://www.postgresql.org/message-id/flat/CAAKRu_ZngzqnEODc7LmS1NH04Kt6Y9huSjz5pp7%2BDXhrjDA0gw%40mail.gmail.com
src/backend/commands/vacuum.c
src/backend/commands/vacuumparallel.c
src/backend/postmaster/autovacuum.c
src/include/commands/vacuum.h
src/include/postmaster/autovacuum.h