Fix failure of btree_gin indexscans with "char" type and </<= operators.
authorTom Lane <tgl@sss.pgh.pa.us>
Tue, 10 Aug 2021 22:10:29 +0000 (18:10 -0400)
committerTom Lane <tgl@sss.pgh.pa.us>
Tue, 10 Aug 2021 22:10:29 +0000 (18:10 -0400)
commita6bd28beb0639d4cf424e961862a65c466ca65bf
tree836db5b4b9079c8ff479624f823afe791ebb2b1e
parent72bbff4cd6eaf55239ccef79cec61766b5f8f1d2
Fix failure of btree_gin indexscans with "char" type and </<= operators.

As a result of confusion about whether the "char" type is signed or
unsigned, scans for index searches like "col < 'x'" or "col <= 'x'"
would start at the middle of the index not the left end, thus missing
many or all of the entries they should find.  Fortunately, this
is not a symptom of index corruption.  It's only the search logic
that is broken, and we can fix it without unpleasant side-effects.

Per report from Jason Kim.  This has been wrong since btree_gin's
beginning, so back-patch to all supported branches.

Discussion: https://postgr.es/m/20210810001649.htnltbh7c63re42p@jasonk.me
contrib/btree_gin/btree_gin.c
contrib/btree_gin/expected/char.out