Reinstate HEAP_XMAX_LOCK_ONLY|HEAP_KEYS_UPDATED as allowed
authorAlvaro Herrera <alvherre@alvh.no-ip.org>
Tue, 23 Feb 2021 20:30:21 +0000 (17:30 -0300)
committerAlvaro Herrera <alvherre@alvh.no-ip.org>
Tue, 23 Feb 2021 20:30:21 +0000 (17:30 -0300)
commit8deb6b38dc4c7a7fd4719ee45e4b00d62b27dffe
tree5f3f90dd0620287eb900edd64cec34b5c0e0fbd4
parent3db05e76f92846d4b54d7de251b0875cf1e23aa4
Reinstate HEAP_XMAX_LOCK_ONLY|HEAP_KEYS_UPDATED as allowed

Commit 866e24d47db1 added an assert that HEAP_XMAX_LOCK_ONLY and
HEAP_KEYS_UPDATED cannot appear together, on the faulty assumption that
the latter necessarily referred to an update and not a tuple lock; but
that's wrong, because SELECT FOR UPDATE can use precisely that
combination, as evidenced by the amcheck test case added here.

Remove the Assert(), and also patch amcheck's verify_heapam.c to not
complain if the combination is found.  Also, out of overabundance of
caution, update (across all branches) README.tuplock to be more explicit
about this.

Author: Julien Rouhaud <rjuju123@gmail.com>
Reviewed-by: Mahendra Singh Thalor <mahi6run@gmail.com>
Reviewed-by: Dilip Kumar <dilipbalaut@gmail.com>
Discussion: https://postgr.es/m/20210124061758.GA11756@nol
contrib/amcheck/t/001_verify_heapam.pl
contrib/amcheck/verify_heapam.c
src/backend/access/heap/README.tuplock
src/backend/access/heap/hio.c