Fix recently added incorrect assertion
authorAlvaro Herrera <alvherre@alvh.no-ip.org>
Mon, 24 Oct 2022 10:02:33 +0000 (12:02 +0200)
committerAlvaro Herrera <alvherre@alvh.no-ip.org>
Mon, 24 Oct 2022 10:02:33 +0000 (12:02 +0200)
commit8328a15f8f95cad3fa99bbab551cade0a8403708
tree7531f49daae15113eb06ac8fe6c183edaf901db0
parent2e0d80c5bb722fb49a4cdc44b0c715ec77c83f79
Fix recently added incorrect assertion

Commit df3737a651f4 added an incorrect assertion about the preconditions
for invoking the backup cleanup callback: it misfires at session end in
case a backup completes successfully.  Fix it, using coding from Michaël
Paquier.  Also add some tests for the various cases.

Reported by Kyotaro Horiguchi <horikyota.ntt@gmail.com>
Discussion: https://postgr.es/m/20221021.161038.1277961198945653224.horikyota.ntt@gmail.com
src/backend/access/transam/xlog.c
src/test/recovery/t/020_archive_status.pl