Remove some pointless code in block.h.
authorTom Lane <tgl@sss.pgh.pa.us>
Fri, 4 Mar 2022 00:15:38 +0000 (19:15 -0500)
committerTom Lane <tgl@sss.pgh.pa.us>
Fri, 4 Mar 2022 00:15:38 +0000 (19:15 -0500)
commit8134fe4ad80a1f9673770126ed7c45045b8ef467
treea8bae5015be7060b4a46aa5ba7e0c355ba59212c
parent0fbdfaf79d0bbfe1ede9d8ca2d85b2c9a8513082
Remove some pointless code in block.h.

There's no visible point in casting the result of a comparison to
bool, because it already is that, at least on C99 compilers.

I see no point in these assertions that a pointer we're about to
dereference isn't null, either.  If it is, the resulting SIGSEGV
will notify us of the problem just fine.

Noted while reviewing Zhihong Yu's patch.  This is basically
cosmetic, so no need for back-patch.

Discussion: https://postgr.es/m/CALNJ-vT9r0DSsAOw9OXVJFxLENoVS_68kJ5x0p44atoYH+H4dg@mail.gmail.com
src/include/storage/block.h