snapshot scalability: Move subxact info to ProcGlobal, remove PGXACT.
authorAndres Freund <andres@anarazel.de>
Fri, 14 Aug 2020 21:30:38 +0000 (14:30 -0700)
committerAndres Freund <andres@anarazel.de>
Fri, 14 Aug 2020 22:33:35 +0000 (15:33 -0700)
commit73487a60fc1063ba4b5178b69aee4ee210c182c4
tree7deec65a2e84e21fced29d0f877729633a04e6c0
parent5788e258bb26495fab65ff3aa486268d1c50b123
snapshot scalability: Move subxact info to ProcGlobal, remove PGXACT.

Similar to the previous changes this increases the chance that data
frequently needed by GetSnapshotData() stays in l2 cache. In many
workloads subtransactions are very rare, and this makes the check for
that considerably cheaper.

As this removes the last member of PGXACT, there is no need to keep it
around anymore.

On a larger 2 socket machine this and the two preceding commits result
in a ~1.07x performance increase in read-only pgbench. For read-heavy
mixed r/w workloads without row level contention, I see about 1.1x.

Author: Andres Freund <andres@anarazel.de>
Reviewed-By: Robert Haas <robertmhaas@gmail.com>
Reviewed-By: Thomas Munro <thomas.munro@gmail.com>
Reviewed-By: David Rowley <dgrowleyml@gmail.com>
Discussion: https://postgr.es/m/20200301083601.ews6hz5dduc3w2se@alap3.anarazel.de
src/backend/access/transam/clog.c
src/backend/access/transam/twophase.c
src/backend/access/transam/varsup.c
src/backend/storage/ipc/procarray.c
src/backend/storage/lmgr/proc.c
src/include/storage/proc.h
src/tools/pgindent/typedefs.list