Change PostgresNode::connect_fails() to never send down queries
authorMichael Paquier <michael@paquier.xyz>
Tue, 6 Apr 2021 00:53:06 +0000 (09:53 +0900)
committerMichael Paquier <michael@paquier.xyz>
Tue, 6 Apr 2021 00:53:06 +0000 (09:53 +0900)
commit6d41dd045ada28ee14182112fc4cf50fb3879d28
tree2ee7911daf6d5dbaf9664e0f4b49ccbfb4be5067
parentf6b8f19a084ce949522fcbc940dc116c034cfc47
Change PostgresNode::connect_fails() to never send down queries

This type of failure is similar to what has been fixed in c757a3da,
where an authentication failure combined with psql pushing a command
down its communication pipe causes a test failure.  This routine is
designed to fail, so sending a query has little sense anyway.

Per buildfarm members gaur and hoverfly, based on an analysis and fix
from Tom Lane.

Discussion: https://postgr.es/m/513200.1617634642@sss.pgh.pa.us
src/test/perl/PostgresNode.pm