Fix instability in contrib/bloom TAP tests.
authorTom Lane <tgl@sss.pgh.pa.us>
Tue, 28 Sep 2021 21:34:31 +0000 (17:34 -0400)
committerTom Lane <tgl@sss.pgh.pa.us>
Tue, 28 Sep 2021 21:34:31 +0000 (17:34 -0400)
commit6bc6bd47cf715c8717a8af3f617957045772d38b
treea29a4988d880a8ae8be29c17275310b09d308468
parent07f8a9e784236a3baf707c59cf80d0f015594ffc
Fix instability in contrib/bloom TAP tests.

It turns out that the instability complained of in commit d3c09b9b1
has an embarrassingly simple explanation.  The test script waits for
the standby to flush incoming WAL to disk, but it should wait for
the WAL to be replayed, since we are testing for the effects of that
to be visible.

While at it, use wait_for_catchup instead of reinventing that logic,
and adjust $Test::Builder::Level to improve future error reports.

Back-patch to v12 where the necessary infrastructure came in
(cf. aforesaid commit).  Also back-patch 7d1aa6bf1 so that the
test will actually get run.

Discussion: https://postgr.es/m/2854602.1632852664@sss.pgh.pa.us
contrib/bloom/t/001_wal.pl