Avoid dereferencing an undefined pointer in DecodeInterval().
authorTom Lane <tgl@sss.pgh.pa.us>
Sun, 12 Feb 2023 17:50:55 +0000 (12:50 -0500)
committerTom Lane <tgl@sss.pgh.pa.us>
Sun, 12 Feb 2023 17:50:55 +0000 (12:50 -0500)
commit5e80d3515488a12f776ba14a07fbb5aa6b3ef013
tree33caf25ddfa79780e2741038f3459e61a36a4c5d
parent156c049beed9d3f243cdceaf89456ea6a2995493
Avoid dereferencing an undefined pointer in DecodeInterval().

Commit e39f99046 moved some code up closer to the start of
DecodeInterval(), without noticing that it had been implicitly
relying on previous checks to reject the case of empty input.
Given empty input, we'd now dereference a pointer that hadn't been
set, possibly leading to a core dump.  (But if we fail to provoke
a SIGSEGV, nothing bad happens, and the expected syntax error is
thrown a bit later.)

Per bug #17788 from Alexander Lakhin.  Back-patch to v15 where
the fault was introduced.

Discussion: https://postgr.es/m/17788-dabac9f98f7eafd5@postgresql.org
src/backend/utils/adt/datetime.c
src/test/regress/expected/interval.out
src/test/regress/sql/interval.sql