Don't duplicate log_checkpoint messages for both of restart and checkpoints.
authorAndres Freund <andres@anarazel.de>
Mon, 20 Oct 2014 23:01:56 +0000 (01:01 +0200)
committerAndres Freund <andres@anarazel.de>
Mon, 20 Oct 2014 23:01:56 +0000 (01:01 +0200)
commit5e5b65f359b7a12c05708585a8e6cd4d80ca2652
tree53fafe4aa1768e4386b6c316ca82a0707a0beaee
parent11abd6c90f1094eaeee32e1c57d250c9db5102cb
Don't duplicate log_checkpoint messages for both of restart and checkpoints.

The duplication originated in cdd46c765, where restartpoints were
introduced.

In LogCheckpointStart's case the duplication actually lead to the
compiler's format string checking not to be effective because the
format string wasn't constant.

Arguably these messages shouldn't be elog(), but ereport() style
messages. That'd even allow to translate the messages... But as
there's more mistakes of that kind in surrounding code, it seems
better to change that separately.
src/backend/access/transam/xlog.c