Use ResourceOwner to track WaitEventSets.
authorHeikki Linnakangas <heikki.linnakangas@iki.fi>
Thu, 23 Nov 2023 11:31:36 +0000 (13:31 +0200)
committerHeikki Linnakangas <heikki.linnakangas@iki.fi>
Thu, 23 Nov 2023 11:31:36 +0000 (13:31 +0200)
commit50c67c2019ab9ade8aa8768bfe604cd802fe8591
tree9dcc8f840dea2de613efaa2bddb1206e8bb1d33c
parent414e75540f058b23377219586abb3008507f7099
Use ResourceOwner to track WaitEventSets.

A WaitEventSet holds file descriptors or event handles (on Windows).
If FreeWaitEventSet is not called, those fds or handles are leaked.
Use ResourceOwners to track WaitEventSets, to clean those up
automatically on error.

This was a live bug in async Append nodes, if a FDW's
ForeignAsyncRequest function failed. (In back branches, I will apply a
more localized fix for that based on PG_TRY-PG_FINALLY.)

The added test doesn't check for leaking resources, so it passed even
before this commit. But at least it covers the code path.

In the passing, fix misleading comment on what the 'nevents' argument
to WaitEventSetWait means.

Report by Alexander Lakhin, analysis and suggestion for the fix by
Tom Lane. Fixes bug #17828.

Reviewed-by: Alexander Lakhin, Thomas Munro
Discussion: https://www.postgresql.org/message-id/472235.1678387869@sss.pgh.pa.us
contrib/postgres_fdw/expected/postgres_fdw.out
contrib/postgres_fdw/sql/postgres_fdw.sql
src/backend/executor/nodeAppend.c
src/backend/libpq/pqcomm.c
src/backend/postmaster/postmaster.c
src/backend/postmaster/syslogger.c
src/backend/storage/ipc/latch.c
src/include/storage/latch.h
src/include/utils/resowner.h