Fix lazy_scan_heap so that it won't mark pages all-frozen too soon.
authorRobert Haas <rhaas@postgresql.org>
Wed, 15 Jun 2016 18:23:39 +0000 (14:23 -0400)
committerRobert Haas <rhaas@postgresql.org>
Wed, 15 Jun 2016 18:30:06 +0000 (14:30 -0400)
commit38e9f90a227d1e60e7b4691d1a71fefaba6059e5
treee7307fb5ea8512cba4bb67174b5c576e8b17beb4
parentc7a25c242ffa29810adc2b5320ec7542fe2928bd
Fix lazy_scan_heap so that it won't mark pages all-frozen too soon.

Commit a892234f830e832110f63fc0a2afce2fb21d1584 added a new bit per
page to the visibility map fork indicating whether the page is
all-frozen, but incorrectly assumed that if lazy_scan_heap chose to
freeze a tuple then that tuple would not need to later be frozen
again. This turns out to be false, because xmin and xmax (and
conceivably xvac, if dealing with tuples from very old releases) could
be frozen at separate times.

Thanks to Andres Freund for help in uncovering and tracking down this
issue.
src/backend/access/heap/heapam.c
src/backend/commands/vacuumlazy.c
src/include/access/heapam_xlog.h