Fix pg_dump assertion failure when dumping pg_catalog.
authorJeff Davis <jdavis@postgresql.org>
Tue, 22 Aug 2023 18:21:36 +0000 (11:21 -0700)
committerJeff Davis <jdavis@postgresql.org>
Tue, 22 Aug 2023 19:50:01 +0000 (12:50 -0700)
commit37188cea0c16f3f27ec65b526ffe12f6469142fc
treed5106835f7e80755dff2cdc5d4615ef96647511d
parenta68458108512890d03da39f0132b829ddd5a69ab
Fix pg_dump assertion failure when dumping pg_catalog.

Commit 396d348b04 did not account for the default collation.

Also, use pg_log_warning() instead of Assert().

Discussion: https://postgr.es/m/ce071503fee88334aa70f360e6e4ea14d48305ee.camel%40j-davis.com
Reviewed-by: Michael Paquier
Backpatch-through: 15
src/bin/pg_dump/pg_dump.c
src/bin/pg_dump/t/002_pg_dump.pl