Fix GiST buffering build to work when there are included columns.
authorTom Lane <tgl@sss.pgh.pa.us>
Mon, 12 Oct 2020 22:01:34 +0000 (18:01 -0400)
committerTom Lane <tgl@sss.pgh.pa.us>
Mon, 12 Oct 2020 22:01:34 +0000 (18:01 -0400)
commit371668a8389d792279bd7aff8ca796e284f595df
tree50391f57d108db509de86267632034707956eca4
parent78c0b6ed273a1262f96efe94004bc92d99865005
Fix GiST buffering build to work when there are included columns.

gistRelocateBuildBuffersOnSplit did not get the memo about which
attribute count to use.  This could lead to a crash if there were
included columns and buffering build was chosen.  (Because there
are random page-split decisions elsewhere in GiST index build,
the crashes are not entirely deterministic.)

Back-patch to v12 where GiST gained support for included columns.

Pavel Borisov

Discussion: https://postgr.es/m/CALT9ZEECCV5m7wvxg46PC-7x-EybUmnpupBGhSFMoAAay+r6HQ@mail.gmail.com
src/backend/access/gist/gistbuildbuffers.c