Guard against reallocation failure in pg_regress
authorDaniel Gustafsson <dgustafsson@postgresql.org>
Thu, 24 Feb 2022 19:58:18 +0000 (20:58 +0100)
committerDaniel Gustafsson <dgustafsson@postgresql.org>
Thu, 24 Feb 2022 19:58:18 +0000 (20:58 +0100)
commit31d8d4740ffb21c9898a21b5018c31e92af6935d
treebc662d7a0cd97701aa408ab1d83442d76586288d
parent6c46e8a5dfc9f49e673d76fc6ae097b81d7740ef
Guard against reallocation failure in pg_regress

realloc() will return NULL on a failed reallocation, so the destination
pointer must be inspected to avoid null pointer dereference.  Further,
assigning the return value to the source pointer leak the allocation in
the case of reallocation failure.  Fix by using pg_realloc instead which
has full error handling.

Reviewed-by: Tom Lane <tgl@sss.pgh.pa.us>
Discussion: https://postgr.es/m/9FC7E603-9246-4C62-B466-A39CFAF454AE@yesql.se
src/test/regress/pg_regress.c