Fix unchecked return value from strdup
authorDaniel Gustafsson <dgustafsson@postgresql.org>
Wed, 20 Dec 2023 21:37:28 +0000 (22:37 +0100)
committerDaniel Gustafsson <dgustafsson@postgresql.org>
Wed, 20 Dec 2023 21:37:28 +0000 (22:37 +0100)
commit30e54d5c5d8fceb7287162c116961fa0627544f5
treebe0dbb47001bb78ca088606fadda3444de8cae7c
parentdc212340058b4e7ecfc5a7a81ec50e7a207bf288
Fix unchecked return value from strdup

The pg_dump compression was using strdup() instead of pg_strdup()
and failed to check the returned pointer for out-of-memory before
dereferencing it. Fix by using pg_strdup() instead which probably
was the intention here in the original patch.

Backpatch to v16 where pg_dump compression was introduced.

Reviewed-by: Tristan Partin <tristan@neon.tech>
Reviewed-by: Nathan Bossart <nathandbossart@gmail.com>
Discussion: https://postgr.es/m/CC661D60-6F4C-474D-B9CF-E789ACA3CEFC@yesql.se
Backpatch-through: 16
src/bin/pg_dump/compress_io.c