Fix misuse of RelOptInfo.unique_for_rels cache by SJE
authorAlexander Korotkov <akorotkov@postgresql.org>
Mon, 8 Jan 2024 22:08:35 +0000 (00:08 +0200)
committerAlexander Korotkov <akorotkov@postgresql.org>
Mon, 8 Jan 2024 22:09:06 +0000 (00:09 +0200)
commit30b4955a4668887044568743debef804b14418ca
tree9f50aaf37ede4ff7a7711148b0b5f12cf6ce0957
parentd3c5f37dd543498cc7c678815d3921823beec9e9
Fix misuse of RelOptInfo.unique_for_rels cache by SJE

When SJE uses RelOptInfo.unique_for_rels cache, it passes filtered quals to
innerrel_is_unique_ext().  That might lead to an invalid match to cache entries
made by previous non self-join checking calls.  Add UniqueRelInfo.self_join
flag to prevent such cases.  Also, fix that SJE should require a strict match
of outerrelids to make sure UniqueRelInfo.extra_clauses are valid.

Reported-by: Alexander Lakhin
Discussion: https://postgr.es/m/4788f781-31bd-9796-d7d6-588a751c8787%40gmail.com
src/backend/optimizer/plan/analyzejoins.c
src/include/nodes/pathnodes.h
src/test/regress/expected/join.out
src/test/regress/sql/join.sql