Improve server code to read files as part of a base backup.
authorRobert Haas <rhaas@postgresql.org>
Wed, 17 Jun 2020 15:39:17 +0000 (11:39 -0400)
committerRobert Haas <rhaas@postgresql.org>
Wed, 17 Jun 2020 15:39:17 +0000 (11:39 -0400)
commit2fd2effc50824a8775a088435a13f47b7a6f3b94
tree6a27fc6920e57757dc10badaa410dc756cb7dee8
parent453e0e3f0ef3202386b553719f628cef93ff95a7
Improve server code to read files as part of a base backup.

Don't use fread(), since that doesn't necessarily set errno. We could
use read() instead, but it's even better to use pg_pread(), which
allows us to avoid some extra calls to seek to the desired location in
the file.

Also, advertise a wait event while reading from a file, as we do for
most other places where we're reading data from files.

Patch by me, reviewed by Hamid Akhtar.

Discussion: http://postgr.es/m/CA+TgmobBw-3573vMosGj06r72ajHsYeKtksT_oTxH8XvTL7DxA@mail.gmail.com
doc/src/sgml/monitoring.sgml
src/backend/postmaster/pgstat.c
src/backend/replication/basebackup.c
src/include/pgstat.h