Raise a WARNING for max_slot_wal_keep_size in pg_createsubscriber.
authorAmit Kapila <akapila@postgresql.org>
Tue, 18 Feb 2025 06:45:43 +0000 (12:15 +0530)
committerAmit Kapila <akapila@postgresql.org>
Tue, 18 Feb 2025 06:45:43 +0000 (12:15 +0530)
commit217919dd0954f54402e8d0a38cd203a740754077
treee9a7a913d7a838bb7e43865a15dbf416210a7e58
parent53d3daa491be458e543dd5bf24d40595e588e4e7
Raise a WARNING for max_slot_wal_keep_size in pg_createsubscriber.

During the pg_createsubscriber execution, it is possible that the required
WAL is removed from the primary/publisher node due to
'max_slot_wal_keep_size'.

This patch raises a WARNING during the '--dry-run' mode if the
'max_slot_wal_keep_size' is set to a non-default value on the
primary/publisher node.

Author: Shubham Khanna <khannashubham1197@gmail.com>
Reviewed-by: Peter Smith <smithpb2250@gmail.com>
Reviewed-by: Hayato Kuroda <kuroda.hayato@fujitsu.com>
Reviewed-by: Vignesh C <vignesh21@gmail.com>
Discussion: https://postgr.es/m/CAHv8Rj+deqsQXOMa7Tck8CBQUbsua=+4AuMVQ2=MPM0f-ZHbjA@mail.gmail.com
doc/src/sgml/ref/pg_createsubscriber.sgml
src/bin/pg_basebackup/pg_createsubscriber.c