initdb: Refactor PG_CMD_PUTS loops
authorPeter Eisentraut <peter@eisentraut.org>
Mon, 5 Dec 2022 22:28:59 +0000 (23:28 +0100)
committerPeter Eisentraut <peter@eisentraut.org>
Mon, 5 Dec 2022 22:33:31 +0000 (23:33 +0100)
commit1bd47d0dca9f63dc26abc00d4912857440cd101c
tree06d34e57821d6b2df126e343b19ce244f994064f
parentd69d01ba9d8d774487032459ebb83d2086715f01
initdb: Refactor PG_CMD_PUTS loops

Keeping the SQL commands that initdb runs in string arrays before
feeding them to PG_CMD_PUTS() seems unnecessarily verbose and
inflexible.  In some cases, the array only has one member.  In other
cases, one might want to use PG_CMD_PRINTF() instead, to parametrize a
command, but that would require breaking up the loop or using
workarounds like replace_token().  Unwind all that; it's much simpler
that way.

Reviewed-by: John Naylor <john.naylor@enterprisedb.com>
Reviewed-by: Andrew Dunstan <andrew@dunslane.net>
Discussion: https://www.postgresql.org/message-id/flat/2c50823b-f453-bb97-e38b-34751c51dcdf%40enterprisedb.com
src/bin/initdb/initdb.c