Free temporary memory when reading TOC
authorDaniel Gustafsson <dgustafsson@postgresql.org>
Wed, 9 Feb 2022 13:12:55 +0000 (14:12 +0100)
committerDaniel Gustafsson <dgustafsson@postgresql.org>
Wed, 9 Feb 2022 13:12:55 +0000 (14:12 +0100)
commit1a29217a00a34162ca0ffac336d83f28132330a6
treeb916d3c5393ef328c4d6956e8ab43201d776f3cd
parentcf29a11ef6467fbb4b246d2086f7eecb1cfa42db
Free temporary memory when reading TOC

ReadStr returns allocated memory which the caller is responsible for
freeing when done with the string. This commit ensures that memory is
freed in one case which used ReadStr in a conditional. While the leak
might not be too concerning, this makes the code consistent across all
ReadStr callsites in ReadToc. Due to the lack of complaints of issues
in production from this, no backpatch is performed at this point.

Author: Bharath Rupireddy, Georgios Kokolatos
Reviewed-by: Kyotaro Horiguchi
Discussion: https://postgr.es/m/oZwKiUxFsVaetG2xOJp7Hwao8F1AKIdfFDQLNJrnwoaxmjyB-45r_aYmhgXHKLcMI3GT24m9L6HafSi2ns7WFxXe0mw2_tIJpD-Z3vb_eyI=@pm.me
src/bin/pg_dump/pg_backup_archiver.c