Replace remaining StrNCpy() by strlcpy()
authorPeter Eisentraut <peter@eisentraut.org>
Mon, 10 Aug 2020 16:51:31 +0000 (18:51 +0200)
committerPeter Eisentraut <peter@eisentraut.org>
Mon, 10 Aug 2020 21:20:37 +0000 (23:20 +0200)
commit1784f278a63866cc144fcd0a2127cadba6a2b7f8
treece0f644de0d3a89fc8b49ff67be8428731cb041b
parentcec57b1a0fbcd3833086ba686897c5883e0a2afc
Replace remaining StrNCpy() by strlcpy()

They are equivalent, except that StrNCpy() zero-fills the entire
destination buffer instead of providing just one trailing zero.  For
all but a tiny number of callers, that's just overhead rather than
being desirable.

Remove StrNCpy() as it is now unused.

In some cases, namestrcpy() is the more appropriate function to use.
While we're here, simplify the API of namestrcpy(): Remove the return
value, don't check for NULL input.  Nothing was using that anyway.
Also, remove a few unused name-related functions.

Reviewed-by: Tom Lane <tgl@sss.pgh.pa.us>
Discussion: https://www.postgresql.org/message-id/flat/44f5e198-36f6-6cdb-7fa9-60e34784daae%402ndquadrant.com
20 files changed:
contrib/pgcrypto/crypt-des.c
src/backend/access/transam/slru.c
src/backend/access/transam/xlogarchive.c
src/backend/catalog/pg_constraint.c
src/backend/commands/indexcmds.c
src/backend/commands/statscmds.c
src/backend/commands/tablecmds.c
src/backend/postmaster/pgstat.c
src/backend/replication/logical/logical.c
src/backend/replication/slot.c
src/backend/utils/adt/formatting.c
src/backend/utils/adt/name.c
src/backend/utils/adt/pg_locale.c
src/backend/utils/adt/ruleutils.c
src/common/exec.c
src/include/c.h
src/include/utils/builtins.h
src/interfaces/ecpg/pgtypeslib/dt_common.c
src/interfaces/ecpg/test/pg_regress_ecpg.c
src/test/modules/ssl_passphrase_callback/ssl_passphrase_func.c