Rename I/O timing statistics columns to shared_blk_{read|write}_time
authorMichael Paquier <michael@paquier.xyz>
Thu, 19 Oct 2023 02:26:40 +0000 (11:26 +0900)
committerMichael Paquier <michael@paquier.xyz>
Thu, 19 Oct 2023 02:26:40 +0000 (11:26 +0900)
commit13d00729d422c84b1764c24251abcc785ea4adb1
tree300f1816da7f1189965a564257e6c8591e166bc3
parent9b103f861ea9d74c4c43e80c5c5dfcdc1e61f4a2
Rename I/O timing statistics columns to shared_blk_{read|write}_time

These two counters, defined in BufferUsage to track respectively the
time spent while reading and writing blocks have historically only
tracked data related to shared buffers, when track_io_timing is enabled.

An upcoming patch to add specific counters for local buffers will take
advantage of this rename as it has come up that no data is currently
tracked for local buffers, and tracking local and shared buffers using
the same fields would be inconsistent with the treatment done for temp
buffers.  Renaming the existing fields clarifies what the block type of
each stats field is.

pg_stat_statement is updated to reflect the rename.  No extension
version bump is required as 5a3423ad8ee17 has done one, affecting v17~.

Author: Nazir Bilal Yavuz
Reviewed-by: Robert Haas, Melanie Plageman
Discussion: https://postgr.es/m/CAN55FZ19Ss279mZuqGbuUNxka0iPbLgYuOQXqAKewrjNrp27VA@mail.gmail.com
contrib/pg_stat_statements/expected/oldextversions.out
contrib/pg_stat_statements/pg_stat_statements--1.10--1.11.sql
contrib/pg_stat_statements/pg_stat_statements.c
doc/src/sgml/pgstatstatements.sgml
src/backend/commands/explain.c
src/backend/executor/instrument.c
src/backend/utils/activity/pgstat_io.c
src/include/executor/instrument.h
src/test/regress/expected/explain.out