Fix segmentation fault that commit ac22929a26 caused.
authorFujii Masao <fujii@postgresql.org>
Wed, 4 Nov 2020 12:49:00 +0000 (21:49 +0900)
committerFujii Masao <fujii@postgresql.org>
Wed, 4 Nov 2020 12:49:00 +0000 (21:49 +0900)
commit113d3591b859fb8dc191bc0599d1ad62d91f1aa4
treea7042dcb343f62589f3d862fca73b3067ea4ba51
parent560564d3addcb6c54e13c1ca8bd11afafbb7ba11
Fix segmentation fault that commit ac22929a26 caused.

Commit ac22929a26 changed recoveryWakeupLatch so that it's reset to
NULL at the end of recovery. This change could cause a segmentation fault
in the buildfarm member 'elver'.

Previously the latch was reset to NULL after calling ShutdownWalRcv().
But there could be a window between ShutdownWalRcv() and the actual
exit of walreceiver. If walreceiver set the latch during that window,
the segmentation fault could happen.

To fix the issue, this commit changes walreceiver so that it sets
the latch only when the latch has not been reset to NULL yet.

Author: Fujii Masao
Discussion: https://postgr.es/m/5c1f8a85-747c-7bf9-241e-dd467d8a3586@iki.fi
src/backend/access/transam/xlog.c