Remove unused totalrows parameter in compute_expr_stats
authorDavid Rowley <drowley@postgresql.org>
Thu, 26 Dec 2024 21:51:22 +0000 (10:51 +1300)
committerDavid Rowley <drowley@postgresql.org>
Thu, 26 Dec 2024 21:51:22 +0000 (10:51 +1300)
The totalrows parameter in compute_expr_stats is unused, so remove it.
This is a static function, so the parameter can easily be added again if
it's ever needed.

Author: Ilia Evdokimov <ilya.evdokimov@tantorlabs.ru>
Discussion: https://postgr.es/m/667b92d2-f953-4fcb-9377-3765f5b94187@tantorlabs.com

src/backend/statistics/extended_stats.c

index 99fdf208dba1c4e4711755fd0a2925e27537e707..d2de7e3d89a66498658d447bb5165239ac7e9066 100644 (file)
@@ -89,9 +89,8 @@ typedef struct AnlExprData
        VacAttrStats *vacattrstat;      /* statistics attrs to analyze */
 } AnlExprData;
 
-static void compute_expr_stats(Relation onerel, double totalrows,
-                                                          AnlExprData *exprdata, int nexprs,
-                                                          HeapTuple *rows, int numrows);
+static void compute_expr_stats(Relation onerel, AnlExprData *exprdata,
+                                                          int nexprs, HeapTuple *rows, int numrows);
 static Datum serialize_expr_stats(AnlExprData *exprdata, int nexprs);
 static Datum expr_fetch_func(VacAttrStatsP stats, int rownum, bool *isNull);
 static AnlExprData *build_expr_data(List *exprs, int stattarget);
@@ -220,9 +219,7 @@ BuildRelationExtStatistics(Relation onerel, bool inh, double totalrows,
                                exprdata = build_expr_data(stat->exprs, stattarget);
                                nexprs = list_length(stat->exprs);
 
-                               compute_expr_stats(onerel, totalrows,
-                                                                  exprdata, nexprs,
-                                                                  rows, numrows);
+                               compute_expr_stats(onerel, exprdata, nexprs, rows, numrows);
 
                                exprstats = serialize_expr_stats(exprdata, nexprs);
                        }
@@ -2107,8 +2104,7 @@ examine_opclause_args(List *args, Node **exprp, Const **cstp,
  * Compute statistics about expressions of a relation.
  */
 static void
-compute_expr_stats(Relation onerel, double totalrows,
-                                  AnlExprData *exprdata, int nexprs,
+compute_expr_stats(Relation onerel, AnlExprData *exprdata, int nexprs,
                                   HeapTuple *rows, int numrows)
 {
        MemoryContext expr_context,