Lock table in DROP STATISTICS
authorTomas Vondra <tomas.vondra@postgresql.org>
Sun, 19 Nov 2023 20:03:29 +0000 (21:03 +0100)
committerTomas Vondra <tomas.vondra@postgresql.org>
Sun, 19 Nov 2023 20:03:38 +0000 (21:03 +0100)
commit28f84f72fbafe3bef675d3a176eb53177f4a9433
treea2854385c0393362cb0f3e001cd1a33aaa838011
parentb218fbb7a35fcf31539bfad12732038fe082a2eb
Lock table in DROP STATISTICS

The DROP STATISTICS code failed to properly lock the table, leading to

  ERROR:  tuple concurrently deleted

when executed concurrently with ANALYZE.

Fixed by modifying RemoveStatisticsById() to acquire the same lock as
ANALYZE. This function is called only by DROP STATISTICS, as ANALYZE
calls RemoveStatisticsDataById() directly.

Reported by Justin Pryzby, fix by me. Backpatch through 12. The code was
like this since it was introduced in 10, but older releases are EOL.

Reported-by: Justin Pryzby
Reviewed-by: Tom Lane
Backpatch-through: 12

Discussion: https://postgr.es/m/ZUuk-8CfbYeq6g_u@pryzbyj2023
src/backend/commands/statscmds.c