Fix corner-case 64-bit integer subtraction bug on some platforms.
authorDean Rasheed <dean.a.rasheed@gmail.com>
Thu, 9 Nov 2023 09:50:23 +0000 (09:50 +0000)
committerDean Rasheed <dean.a.rasheed@gmail.com>
Thu, 9 Nov 2023 09:50:23 +0000 (09:50 +0000)
commit0e3e8fbd3a8b1660b02a5bb032dc1f50e1d66b19
treedd7bb4e35697c78cc4823b45f71641bd23f13fc6
parenta7db71ed2787e7dbf2c41473a2b7df2fcb55abd0
Fix corner-case 64-bit integer subtraction bug on some platforms.

When computing "0 - INT64_MIN", most platforms would report an
overflow error, which is correct. However, platforms without integer
overflow builtins or 128-bit integers would fail to spot the overflow,
and incorrectly return INT64_MIN.

Back-patch to all supported branches.

Patch be me. Thanks to Jian He for initial investigation, and Laurenz
Albe and Tom Lane for review.

Discussion: https://postgr.es/m/CAEZATCUNK-AZSD0jVdgkk0N%3DNcAXBWeAEX-QU9AnJPensikmdQ%40mail.gmail.com
src/include/common/int.h
src/test/regress/expected/int8.out
src/test/regress/sql/int8.sql