From d5a7bd5670c4a59bea506f5999101a8e40ef256c Mon Sep 17 00:00:00 2001 From: Heikki Linnakangas Date: Fri, 20 Dec 2024 19:36:33 +0200 Subject: [PATCH] Fix variable reference in comment This used to say "nsubxcnt isn't decreased when subtransactions abort", but there's no variable called nsubxcnt. Commit 8548ddc61b changed it to "subxcnt", among other typo fixes, but that was wrong too: the comment actually talks about txn->nsubtxns. That's the field that's incremented but never decremented and is used for the allocation earlier in the function. --- src/backend/replication/logical/reorderbuffer.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/backend/replication/logical/reorderbuffer.c b/src/backend/replication/logical/reorderbuffer.c index e3a5c7b660c..9313d2b01e1 100644 --- a/src/backend/replication/logical/reorderbuffer.c +++ b/src/backend/replication/logical/reorderbuffer.c @@ -1861,9 +1861,9 @@ ReorderBufferCopySnap(ReorderBuffer *rb, Snapshot orig_snap, snap->subxip[i++] = txn->xid; /* - * subxcnt isn't decreased when subtransactions abort, so count manually. - * Since it's an upper boundary it is safe to use it for the allocation - * above. + * txn->nsubtxns isn't decreased when subtransactions abort, so count + * manually. Since it's an upper boundary it is safe to use it for the + * allocation above. */ snap->subxcnt = 1; -- 2.39.5