From 9e496768b8a7303ea07888ea1baae8e2a57dda7b Mon Sep 17 00:00:00 2001 From: Tom Lane Date: Mon, 3 Aug 2020 14:02:35 -0400 Subject: [PATCH] Remove unnecessary "DISTINCT" in psql's queries for \dAc and \dAf. A moment's examination of these queries is sufficient to see that they do not produce duplicate rows, unless perhaps there's catalog corruption. Using DISTINCT anyway is inefficient and confusing; moreover it sets a poor example for anyone who refers to psql -E output to see how to query the catalogs. --- src/bin/psql/describe.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/bin/psql/describe.c b/src/bin/psql/describe.c index 57266f4fc35..d81f1575bf4 100644 --- a/src/bin/psql/describe.c +++ b/src/bin/psql/describe.c @@ -6071,7 +6071,7 @@ listOperatorClasses(const char *access_method_pattern, initPQExpBuffer(&buf); printfPQExpBuffer(&buf, - "SELECT DISTINCT" + "SELECT\n" " am.amname AS \"%s\",\n" " pg_catalog.format_type(c.opcintype, NULL) AS \"%s\",\n" " CASE\n" @@ -6166,7 +6166,7 @@ listOperatorFamilies(const char *access_method_pattern, initPQExpBuffer(&buf); printfPQExpBuffer(&buf, - "SELECT DISTINCT" + "SELECT\n" " am.amname AS \"%s\",\n" " CASE\n" " WHEN pg_catalog.pg_opfamily_is_visible(f.oid)\n" -- 2.30.2