From 7524671bd042bffa70de37b1d38403c25aaf57dd Mon Sep 17 00:00:00 2001 From: Tom Lane Date: Thu, 11 Jun 2009 19:00:15 +0000 Subject: [PATCH] Remove our inadequate kluge that tried to get AIX's various broken versions of getaddrinfo() to work. Instead, recommend updating the OS to get a working version of getaddrinfo. Per recent discussions. --- doc/src/sgml/installation.sgml | 113 ++++++++++++++++++--------------- src/backend/libpq/ip.c | 36 ----------- 2 files changed, 63 insertions(+), 86 deletions(-) diff --git a/doc/src/sgml/installation.sgml b/doc/src/sgml/installation.sgml index be544df806..bc006214a1 100644 --- a/doc/src/sgml/installation.sgml +++ b/doc/src/sgml/installation.sgml @@ -2090,7 +2090,7 @@ kill `cat /usr/local/pgsql/data/postmaster.pid` On AIX 4.3.2, you need libm.a that is in the - fileset bos.adt.libm. Try the following command: + fileset bos.adt.libm. Try the following command: $ lslpp -l bos.adt.libm @@ -2120,11 +2120,11 @@ $ lslpp -l bos.adt.libm AIX 5.3 has a problem - where sockadr_storage is not defined to + where sockaddr_storage is not defined to be large enough. In version 5.3, IBM increased the size of sockaddr_un, the address structure for Unix-domain sockets, but did not correspondingly increase the - size of sockadr_storage. The result of + size of sockaddr_storage. The result of this is that attempts to use Unix-domain sockets with PostgreSQL lead to libpq overflowing the data structure. TCP/IP connections work OK, but not Unix-domain sockets, which prevents the @@ -2142,7 +2142,66 @@ $ lslpp -l bos.adt.libm - Memory Management + Internet address issues + + + PostgreSQL relies on the system's getaddrinfo function + to parse IP addresses in listen_addresses, + pg_hba.conf, etc. Older versions of AIX have assorted + bugs in this function. If you have problems related to these settings, + updating to the latest fix pack for your AIX release should fix it. + + + + + + One user reports: + + + + When implementing PostgreSQL version 8.1 on AIX 5.3, we + periodically ran into problems where the statistics collector + would mysteriously not come up successfully. This + appears to be the result of unexpected behaviour in the IPv6 + implementation. It looks like PostgreSQL and IPv6 do not play + very well together at this time on AIX. + + + + Any of the following actions fix the problem. + + + + Delete the IPv6 address for localhost: + +(as root) +# ifconfig lo0 inet6 ::1/0 delete + + + + + + + Remove IPv6 from net services. The + file /etc/netsvc.conf on AIX is roughly + equivalent to /etc/nsswitch.conf on + Solaris/Linux. The default, on AIX, is thus: + +hosts=local,bind + + Replace this with: + +hosts=local4,bind4 + + to deactivate searching for IPv6 addresses. + + + + + + + + Memory management @@ -2292,52 +2351,6 @@ createlang: language installation failed: ERROR: could not load library "/opt/d - - - Statistics Collector Issues - - - - When implementing PostgreSQL version 8.1 on AIX 5.3, we - periodically ran into problems where the statistics collector - would mysteriously not come up successfully. This - appears to be the result of unexpected behaviour in the IPv6 - implementation. It looks like PostgreSQL and IPv6 do not play - very well together at this time on AIX. - - - - Any of the following actions fix the problem. - - - - Delete the IPv6 address for localhost: - -(as root) -# ifconfig lo0 inet6 ::1/0 delete - - - - - - - Remove IPv6 from net services. The - file /etc/netsvc.conf on AIX is roughly - equivalent to /etc/nsswitch.conf on - Solaris/Linux. The default, on AIX, is thus: - -hosts=local,bind - - Replace this with: - -hosts=local4,bind4 - - to deactivate searching for IPv6 addresses. - - - - - diff --git a/src/backend/libpq/ip.c b/src/backend/libpq/ip.c index eb53175967..0c35ddd7d7 100644 --- a/src/backend/libpq/ip.c +++ b/src/backend/libpq/ip.c @@ -74,45 +74,9 @@ pg_getaddrinfo_all(const char *hostname, const char *servname, return getaddrinfo_unix(servname, hintp, result); #endif -#ifndef _AIX /* NULL has special meaning to getaddrinfo(). */ rc = getaddrinfo((!hostname || hostname[0] == '\0') ? NULL : hostname, servname, hintp, result); -#else /* _AIX */ - - /* - * Various versions of AIX have various bugs in getaddrinfo()'s handling - * of the servname parameter, including failing entirely if it's not NULL - * and failing to zero sin_port when it is NULL :-(. Avoid these by - * always passing NULL and handling the port number for ourselves. - */ - rc = getaddrinfo((!hostname || hostname[0] == '\0') ? NULL : hostname, - NULL, hintp, result); - - if (rc == 0) - { - struct addrinfo *addr; - unsigned short port = 0; - - if (servname && *servname) - port = atoi(servname); - - for (addr = *result; addr; addr = addr->ai_next) - { - switch (addr->ai_family) - { - case AF_INET: - ((struct sockaddr_in *) addr->ai_addr)->sin_port = htons(port); - break; -#ifdef HAVE_IPV6 - case AF_INET6: - ((struct sockaddr_in6 *) addr->ai_addr)->sin6_port = htons(port); - break; -#endif - } - } - } -#endif /* _AIX */ return rc; } -- 2.30.2