From 1384847ef8731718a79a32cd354e31c31c5294a0 Mon Sep 17 00:00:00 2001 From: Joe Conway Date: Sat, 12 Sep 2009 23:20:52 +0000 Subject: [PATCH] plug dblink resource leak dblink generates orphaned connections when called with a connection string, fail_on_error = true, and an ERROR occurs. Discovery and patch by Tatsuhito Kasahara. Introduced in 8.4. --- contrib/dblink/dblink.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/contrib/dblink/dblink.c b/contrib/dblink/dblink.c index 83b334c4f6..72fdf56a71 100644 --- a/contrib/dblink/dblink.c +++ b/contrib/dblink/dblink.c @@ -855,9 +855,9 @@ dblink_record_internal(FunctionCallInfo fcinfo, bool is_async) (PQresultStatus(res) != PGRES_COMMAND_OK && PQresultStatus(res) != PGRES_TUPLES_OK)) { - dblink_res_error(conname, res, "could not execute query", fail); if (freeconn) PQfinish(conn); + dblink_res_error(conname, res, "could not execute query", fail); MemoryContextSwitchTo(oldcontext); SRF_RETURN_DONE(funcctx); } -- 2.39.5