Change fastgetattr and heap_getattr to inline functions
authorAlvaro Herrera <alvherre@alvh.no-ip.org>
Thu, 24 Mar 2022 17:02:27 +0000 (18:02 +0100)
committerAlvaro Herrera <alvherre@alvh.no-ip.org>
Thu, 24 Mar 2022 17:02:27 +0000 (18:02 +0100)
commite27f4ee0a701854daf16ac1d044f20d28a17053e
tree433036a4ca934feb90651ce134ab36ec66a9c926
parent0bd7af082ace135581bb13a6bd2d88e68c66a3e0
Change fastgetattr and heap_getattr to inline functions

They were macros previously, but recent callsite additions made Coverity
complain about one of the assertions being always true.  This change
could have been made a long time ago, but the Coverity complain broke
the inertia.

Reviewed-by: Michael Paquier <michael@paquier.xyz>
Reviewed-by: Japin Li <japinli@hotmail.com>
Reviewed-by: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
Discussion: https://postgr.es/m/202203241021.uts52sczx3al@alvherre.pgsql
src/backend/access/heap/heapam.c
src/include/access/htup_details.h