For inplace update durability, make heap_update() callers wait.
authorNoah Misch <noah@leadboat.com>
Tue, 24 Sep 2024 22:25:18 +0000 (15:25 -0700)
committerNoah Misch <noah@leadboat.com>
Tue, 24 Sep 2024 22:25:18 +0000 (15:25 -0700)
commitaac2c9b4fde889d13f859c233c2523345e72d32b
tree65d5e1b73059d4c423dee459bcf58bc0c47b8a9a
parenta07e03fd8fa7daf4d1356f7cb501ffe784ea6257
For inplace update durability, make heap_update() callers wait.

The previous commit fixed some ways of losing an inplace update.  It
remained possible to lose one when a backend working toward a
heap_update() copied a tuple into memory just before inplace update of
that tuple.  In catalogs eligible for inplace update, use LOCKTAG_TUPLE
to govern admission to the steps of copying an old tuple, modifying it,
and issuing heap_update().  This includes MERGE commands.  To avoid
changing most of the pg_class DDL, don't require LOCKTAG_TUPLE when
holding a relation lock sufficient to exclude inplace updaters.
Back-patch to v12 (all supported versions).  In v13 and v12, "UPDATE
pg_class" or "UPDATE pg_database" can still lose an inplace update.  The
v14+ UPDATE fix needs commit 86dc90056dfdbd9d1b891718d2e5614e3e432f35,
and it wasn't worth reimplementing that fix without such infrastructure.

Reviewed by Nitin Motiani and (in earlier versions) Heikki Linnakangas.

Discussion: https://postgr.es/m/20231027214946.79.nmisch@google.com
20 files changed:
src/backend/access/heap/README.tuplock
src/backend/access/heap/heapam.c
src/backend/access/index/genam.c
src/backend/catalog/aclchk.c
src/backend/catalog/catalog.c
src/backend/commands/dbcommands.c
src/backend/commands/event_trigger.c
src/backend/commands/indexcmds.c
src/backend/commands/tablecmds.c
src/backend/executor/execMain.c
src/backend/executor/execReplication.c
src/backend/executor/nodeModifyTable.c
src/backend/utils/cache/relcache.c
src/backend/utils/cache/syscache.c
src/include/nodes/execnodes.h
src/include/storage/lockdefs.h
src/include/utils/syscache.h
src/test/isolation/expected/intra-grant-inplace.out
src/test/isolation/specs/eval-plan-qual.spec
src/test/isolation/specs/intra-grant-inplace.spec