Use CP_SMALL_TLIST for hash aggregate
authorTomas Vondra <tomas.vondra@postgresql.org>
Sun, 31 May 2020 12:43:13 +0000 (14:43 +0200)
committerTomas Vondra <tomas.vondra@postgresql.org>
Sun, 31 May 2020 12:43:13 +0000 (14:43 +0200)
commit4cad2534da6d17067d98cf04be2dfc1bda8f2cd0
tree5b27dc496791ec122500851a35f3f63d46147828
parent9b60c4b979bce060495e2b05ba01d1cc6bffdd2d
Use CP_SMALL_TLIST for hash aggregate

Commit 1f39bce021 added disk-based hash aggregation, which may spill
incoming tuples to disk. It however did not request projection to make
the tuples as narrow as possible, which may mean having to spill much
more data than necessary (increasing I/O, pushing other stuff from page
cache, etc.).

This adds CP_SMALL_TLIST in places that may use hash aggregation - we do
that only for AGG_HASHED. It's unnecessary for AGG_SORTED, because that
either uses explicit Sort (which already does projection) or pre-sorted
input (which does not need spilling to disk).

Author: Tomas Vondra
Reviewed-by: Jeff Davis
Discussion: https://postgr.es/m/20200519151202.u2p2gpiawoaznsv2%40development
contrib/postgres_fdw/expected/postgres_fdw.out
src/backend/optimizer/plan/createplan.c